Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apk upload read/write timeout + surface potential errors #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ccaruceru
Copy link

@ccaruceru ccaruceru commented Jul 13, 2023

  • Add extra parameter to set read and write timeouts to let users adjust them when uploading big apks (over 500mb)
    • recommended value for large apks: transport_timeout:1800
  • Throw errors using UI.crash so users invoking the plugin via one off runs do exit with non zero exit code whenever there is an error
    [bundle exec] fastlane run amazon_app_submission [params...]
    
  • Fix a bug when second try of replaceExistingApk didn't return new values
  • Add support to upload the apk when there is no attached one on the Edit. This usually happens when the user manually deletes the apk from the web portal.

README.md Outdated Show resolved Hide resolved
@ccaruceru
Copy link
Author

@mohammedhemaid hi! any chance you can have a look at this? 🙏🏻

@ccaruceru
Copy link
Author

@mohammedhemaid kind reminder 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants