Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why start loading is just a action method but endLoading is setter? #3

Closed
ipepe opened this issue May 26, 2016 · 5 comments
Closed
Labels

Comments

@ipepe
Copy link

ipepe commented May 26, 2016

Why start loading is just a action method but endLoading is setter?

@ugurcany
Copy link
Owner

ugurcany commented May 26, 2016

There are both startLoading and stopLoading action methods. See the example and also the README file. The method setEndOfLoading has a different purpose. It indicates there are no more items to load. For instance, you are retrieving paged data from a server. When you consume all pages, you need to call setEndOfLoading(true) to tell the view that it should not try to load more when you swipe to the bottom again.

@ipepe
Copy link
Author

ipepe commented May 26, 2016

shouldn't that be also action?

@ipepe
Copy link
Author

ipepe commented May 26, 2016

also I would rename it to something like hasMore = false?

@ugurcany
Copy link
Owner

You can fork and rename it as you wish.

@ugurcany
Copy link
Owner

setEndOfLoading method name changed to hasMore.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants