Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error titles should not be printed for merged messages #883

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Dec 21, 2023

When the logger has only errors from merged reports, then the own error title should be skipped.

@uhafner uhafner added the bug Bugs or performance problems label Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (523cefc) 88.85% compared to head (4eb1cf6) 88.81%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #883      +/-   ##
============================================
- Coverage     88.85%   88.81%   -0.05%     
  Complexity      173      173              
============================================
  Files            11       11              
  Lines           709      706       -3     
  Branches         90       89       -1     
============================================
- Hits            630      627       -3     
  Misses           63       63              
  Partials         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

☀️ Quality Monitor

  • 🚦 Tests: 93 tests passed, 2 skipped
  • 👣 Code Coverage: 91% coverage achieved
  • 🔬 Mutation Coverage: 80% mutations killed
  • ⚠️ Style: No warnings found
  • 🐛 Bugs: No warnings found

More details are available in the GitHub Checks Result.

@uhafner uhafner merged commit d6fc9f8 into main Dec 21, 2023
16 of 17 checks passed
@uhafner uhafner deleted the merge-errors branch December 21, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant