Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The -n param, the max number of edges, is ignored in the code #35

Open
chanind opened this issue May 16, 2021 · 0 comments · May be fixed by #36
Open

The -n param, the max number of edges, is ignored in the code #35

chanind opened this issue May 16, 2021 · 0 comments · May be fixed by #36

Comments

@chanind
Copy link

chanind commented May 16, 2021

The -n param option specifies the number of edges in the ego graph, but it looks like in the code this param is accidentally ignored. This param is passed through to word_sense_induction.py#L66 as max_related, but that param is never read. It looks like the intention is to set the global var n to that value, and then use that in word_sense_induction.py#L56 to limit the size of the cluster. However, this is never set in the code and n remains set to None.

@chanind chanind changed the title The -n param, the cluster size, is ignored in the code The -n param, the max number of edges, is ignored in the code May 16, 2021
@chanind chanind linked a pull request May 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant