Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle binary files in/out #7

Merged
merged 1 commit into from
Nov 20, 2022
Merged

fix: handle binary files in/out #7

merged 1 commit into from
Nov 20, 2022

Conversation

uhmarcel
Copy link
Owner

No description provided.

@github-actions
Copy link

Test Results

14 tests  +2   14 ✔️ +2   0s ⏱️ ±0s
  4 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4dcc212. ± Comparison against base commit 4ed8d10.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
given_input_arg_expect_encoded_string_in_stdout

given_binary_file_input_arg_expect_encoded_string_in_stdout
given_non_utf8_encoded_binary_and_output_arg_expect_decoded_binary_file
given_text_file_input_arg_expect_encoded_string_in_stdout

@github-actions
Copy link

github-actions bot commented Nov 20, 2022 •
edited

Profiling Report

encode/3                time:   [37.307 ns 37.335 ns 37.363 ns]
                        thrpt:  [76.573 MiB/s 76.630 MiB/s 76.688 MiB/s]
                 change:
                        time:   [-0.1692% -0.0479% +0.0709%] (p = 0.45 > 0.05)
                        thrpt:  [-0.0708% +0.0479% +0.1695%]
                        No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
encode/50               time:   [84.769 ns 84.823 ns 84.877 ns]
                        thrpt:  [561.80 MiB/s 562.16 MiB/s 562.51 MiB/s]
                 change:
+                        time:   [-8.2196% -8.1248% -8.0220%] (p = 0.00 < 0.05)
+                        thrpt:  [+8.7216% +8.8433% +8.9558%]
+                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
encode/100              time:   [126.71 ns 126.76 ns 126.82 ns]
                        thrpt:  [751.99 MiB/s 752.32 MiB/s 752.62 MiB/s]
                 change:
+                        time:   [-11.757% -11.680% -11.602%] (p = 0.00 < 0.05)
+                        thrpt:  [+13.125% +13.224% +13.323%]
+                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) low severe
  3 (3.00%) high mild
encode/500              time:   [379.54 ns 379.58 ns 379.64 ns]
                        thrpt:  [1.2266 GiB/s 1.2268 GiB/s 1.2269 GiB/s]
                 change:
+                        time:   [-4.8119% -4.7868% -4.7623%] (p = 0.00 < 0.05)
+                        thrpt:  [+5.0004% +5.0275% +5.0551%]
+                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) low mild
  2 (2.00%) high mild
  2 (2.00%) high severe
encode/3072             time:   [2.0427 µs 2.0428 µs 2.0430 µs]
                        thrpt:  [1.4004 GiB/s 1.4005 GiB/s 1.4006 GiB/s]
                 change:
                        time:   [-0.3728% -0.1880% -0.0686%] (p = 0.00 < 0.05)
                        thrpt:  [+0.0686% +0.1883% +0.3742%]
                        Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  3 (3.00%) high severe
encode/51200            time:   [33.580 µs 33.583 µs 33.587 µs]
                        thrpt:  [1.4197 GiB/s 1.4199 GiB/s 1.4200 GiB/s]
                 change:
                        time:   [+0.0147% +0.0420% +0.0805%] (p = 0.01 < 0.05)
                        thrpt:  [-0.0804% -0.0420% -0.0147%]
                        Change within noise threshold.
Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
  3 (3.00%) high severe
encode/102400           time:   [67.278 µs 67.287 µs 67.299 µs]
                        thrpt:  [1.4171 GiB/s 1.4173 GiB/s 1.4175 GiB/s]
                 change:
                        time:   [-0.0338% -0.0003% +0.0248%] (p = 0.99 > 0.05)
                        thrpt:  [-0.0248% +0.0003% +0.0338%]
                        No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
  1 (1.00%) low severe
  2 (2.00%) low mild
  3 (3.00%) high mild
  4 (4.00%) high severe
encode/512000           time:   [795.17 µs 806.69 µs 823.51 µs]
                        thrpt:  [592.92 MiB/s 605.29 MiB/s 614.06 MiB/s]
                 change:
                        time:   [-1.5124% -0.0485% +1.6311%] (p = 0.95 > 0.05)
                        thrpt:  [-1.6049% +0.0485% +1.5356%]
                        No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) high mild
  4 (4.00%) high severe
encode/1048576          time:   [1.6021 ms 1.6052 ms 1.6091 ms]
                        thrpt:  [621.46 MiB/s 622.99 MiB/s 624.19 MiB/s]
                 change:
                        time:   [-0.5171% -0.2511% +0.0019%] (p = 0.07 > 0.05)
                        thrpt:  [-0.0019% +0.2517% +0.5198%]
                        No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
  5 (5.00%) high mild
  4 (4.00%) high severe
encode/5242880          time:   [7.8387 ms 7.8855 ms 7.9670 ms]
                        thrpt:  [627.59 MiB/s 634.08 MiB/s 637.86 MiB/s]
                 change:
                        time:   [+0.0622% +0.6894% +1.6751%] (p = 0.12 > 0.05)
                        thrpt:  [-1.6475% -0.6846% -0.0622%]
                        No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) high mild
  2 (2.00%) high severe
encode/10485760         time:   [15.902 ms 15.952 ms 16.008 ms]
                        thrpt:  [624.68 MiB/s 626.89 MiB/s 628.85 MiB/s]
                 change:
                        time:   [-0.7191% +0.0817% +0.7346%] (p = 0.83 > 0.05)
                        thrpt:  [-0.7293% -0.0816% +0.7243%]
                        No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe
encode/20971520         time:   [32.783 ms 32.970 ms 33.279 ms]
                        thrpt:  [600.98 MiB/s 606.61 MiB/s 610.08 MiB/s]
                 change:
                        time:   [-0.0658% +0.5505% +1.4380%] (p = 0.21 > 0.05)
                        thrpt:  [-1.4176% -0.5475% +0.0658%]
                        No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

decode/3                time:   [53.882 ns 53.944 ns 54.009 ns]
                        thrpt:  [52.973 MiB/s 53.037 MiB/s 53.098 MiB/s]
                 change:
                        time:   [-0.9333% -0.1832% +0.3373%] (p = 0.65 > 0.05)
                        thrpt:  [-0.3361% +0.1836% +0.9421%]
                        No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) low mild
  2 (2.00%) high mild
  1 (1.00%) high severe
decode/50               time:   [76.816 ns 76.878 ns 76.940 ns]
                        thrpt:  [619.75 MiB/s 620.25 MiB/s 620.75 MiB/s]
                 change:
                        time:   [-0.7283% -0.5666% -0.4173%] (p = 0.00 < 0.05)
                        thrpt:  [+0.4190% +0.5698% +0.7336%]
                        Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) low mild
  1 (1.00%) high mild
  1 (1.00%) high severe
decode/100              time:   [110.05 ns 110.13 ns 110.20 ns]
                        thrpt:  [865.37 MiB/s 865.97 MiB/s 866.56 MiB/s]
                 change:
                        time:   [-0.9845% -0.8610% -0.7297%] (p = 0.00 < 0.05)
                        thrpt:  [+0.7351% +0.8684% +0.9943%]
                        Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
decode/500              time:   [398.85 ns 399.01 ns 399.19 ns]
                        thrpt:  [1.1665 GiB/s 1.1670 GiB/s 1.1675 GiB/s]
                 change:
-                        time:   [+4.2138% +4.3989% +4.5463%] (p = 0.00 < 0.05)
-                        thrpt:  [-4.3486% -4.2136% -4.0434%]
-                        Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) high mild
  3 (3.00%) high severe
decode/3072             time:   [1.9982 µs 1.9988 µs 1.9993 µs]
                        thrpt:  [1.4310 GiB/s 1.4314 GiB/s 1.4318 GiB/s]
                 change:
                        time:   [+0.1078% +0.1426% +0.1799%] (p = 0.00 < 0.05)
                        thrpt:  [-0.1795% -0.1424% -0.1077%]
                        Change within noise threshold.
Found 8 outliers among 100 measurements (8.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
  4 (4.00%) high severe
decode/51200            time:   [31.675 µs 31.678 µs 31.681 µs]
                        thrpt:  [1.5051 GiB/s 1.5053 GiB/s 1.5054 GiB/s]
                 change:
                        time:   [-0.0093% +0.0083% +0.0263%] (p = 0.37 > 0.05)
                        thrpt:  [-0.0263% -0.0083% +0.0093%]
                        No change in performance detected.
Found 12 outliers among 100 measurements (12.00%)
  2 (2.00%) low severe
  1 (1.00%) low mild
  6 (6.00%) high mild
  3 (3.00%) high severe
decode/102400           time:   [63.536 µs 63.547 µs 63.561 µs]
                        thrpt:  [1.5004 GiB/s 1.5007 GiB/s 1.5010 GiB/s]
                 change:
                        time:   [-0.0762% -0.0264% +0.0111%] (p = 0.27 > 0.05)
                        thrpt:  [-0.0111% +0.0264% +0.0762%]
                        No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
  3 (3.00%) low mild
  2 (2.00%) high mild
  3 (3.00%) high severe
decode/512000           time:   [489.43 µs 490.22 µs 491.17 µs]
                        thrpt:  [994.12 MiB/s 996.05 MiB/s 997.65 MiB/s]
                 change:
+                        time:   [-5.7959% -4.2095% -2.8491%] (p = 0.00 < 0.05)
+                        thrpt:  [+2.9326% +4.3945% +6.1525%]
+                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  7 (7.00%) high mild
  3 (3.00%) high severe
decode/1048576          time:   [1.0038 ms 1.0048 ms 1.0062 ms]
                        thrpt:  [993.83 MiB/s 995.22 MiB/s 996.25 MiB/s]
                 change:
+                        time:   [-3.7322% -2.5031% -1.4160%] (p = 0.00 < 0.05)
+                        thrpt:  [+1.4363% +2.5673% +3.8769%]
+                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  1 (1.00%) low severe
  1 (1.00%) low mild
  3 (3.00%) high mild
  5 (5.00%) high severe
decode/5242880          time:   [4.9440 ms 4.9524 ms 4.9624 ms]
                        thrpt:  [1007.6 MiB/s 1009.6 MiB/s 1011.3 MiB/s]
                 change:
                        time:   [-0.6972% -0.2618% +0.1329%] (p = 0.23 > 0.05)
                        thrpt:  [-0.1327% +0.2624% +0.7021%]
                        No change in performance detected.
Found 11 outliers among 100 measurements (11.00%)
  7 (7.00%) high mild
  4 (4.00%) high severe
decode/10485760         time:   [9.9090 ms 9.9724 ms 10.056 ms]
                        thrpt:  [994.45 MiB/s 1002.8 MiB/s 1009.2 MiB/s]
                 change:
                        time:   [-0.2214% +0.4143% +1.3682%] (p = 0.34 > 0.05)
                        thrpt:  [-1.3497% -0.4126% +0.2219%]
                        No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) high mild
  4 (4.00%) high severe
decode/20971520         time:   [20.066 ms 20.093 ms 20.121 ms]
                        thrpt:  [994.00 MiB/s 995.39 MiB/s 996.73 MiB/s]
                 change:
                        time:   [-1.2798% -0.6327% -0.0984%] (p = 0.03 < 0.05)
                        thrpt:  [+0.0985% +0.6367% +1.2963%]
                        Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

@uhmarcel uhmarcel merged commit 0050529 into main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@uhmarcel