Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add App module #137

Merged
merged 7 commits into from Feb 9, 2023
Merged

Add App module #137

merged 7 commits into from Feb 9, 2023

Conversation

uhooi
Copy link
Owner

@uhooi uhooi commented Feb 8, 2023 •
edited

Description

  • App module was created so that Feature modules do not depend on each other
  • Moved NavigationStack to the App module

Reference

@uhooi uhooi self-assigned this Feb 8, 2023
@uhooi uhooi marked this pull request as ready for review February 8, 2023 15:30
yoshiysh
yoshiysh reviewed Feb 9, 2023
View reviewed changes
Copy link

@yoshiysh yoshiysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

画面遷移がほぼないのでシンプルなのは問題ないかと！

LokiPackage/Sources/Apps/Develop/DevelopRouter.swift Outdated Show resolved Hide resolved
@uhooi uhooi merged commit 313cbc8 into main Feb 9, 2023
@uhooi uhooi deleted the feature/add_app_module branch February 9, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshiysh yoshiysh yoshiysh left review comments

Assignees

@uhooi uhooi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uhooi @yoshiysh