-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odd issue with re2 after resetting yarn.lock file #94
Comments
I'm trying to narrow down which version this bug happens in, one moment... |
I can't seem to narrow this down to |
Okay so as soon as I remove |
When I have time I will write more tests for I suggest going back to 1.15.4 for now and bump it back when the problem is fixed on my side (if it is my problem, which currently looks very likely). |
Here's a yarn lock diff, I tried 1.15.4 and it doesn't work still. https://gist.github.com/niftylettuce/be299a638efd055f57a6489ef7d434b9 |
I've even tried using npm directly via https://github.com/rogeriochaves/npm-force-resolutions and it still does not work. There is something quite odd going on here. |
This does not seem to be a problem with re2, at least I think... it seems like it is though - but I've locked version everywhere to 1.15.4, but the issue still persists. |
I also upgraded from Node v12 LTS to Node v14 LTS recently, investigating this now. |
Not a Node v12 vs v14 issue, just tested. |
My guess is it's something to do with Ava/Babel at this point but I'm still investigating. |
Is it possible that Babel compiles/transforms code that it shouldn't? It could be tested by creating a simple file, which does just one operation that fails and see if it works or not. Then, depending on results, inspect the offending code to find a difference, if there is one. I had a problem in the past (not related to |
Ah-ha. I figured it out, it seems that |
Found it. sindresorhus/ip-regex@4147df0 |
Thanks for your help and being here @uhop ❤️ |
This seems like
re2
related, but I thought we should major bump on breaking changes inre2
here. I guess not though, and we have to be extra safe.Here's a code example which shows the breaking change:
You can reproduce this by:
You'll see the same error here.
If you use
"resolutions"
field to lock it, then the error goes away.Previous builds were running fine on v1.15.4 in the past, but if I rebuild it will error. See https://travis-ci.com/spamscanner/spamscanner.
The text was updated successfully, but these errors were encountered: