fix: make 2nd argument(routeDefinition) optional

Issue: #10
uhyo · Jan 7, 2021 · 1d9695c · 1d9695c
1 parent e01be24
commit 1d9695c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/builder/PathRouteBuilder/PathRouteBuilder.test.ts b/src/builder/PathRouteBuilder/PathRouteBuilder.test.ts
@@ -193,6 +193,22 @@ describe("PathRouteBuilder", () => {
         state: null,
       });
     });
+    it("any works without routeDefinition(2nd argument)", () => {
+      const res = PathRouteBuilder.init<string>().any("id");
+      const subRoutes = res.anyRoute
+        .attach(PathRouteBuilder.init())
+        .routes({
+          hoge: {
+            action: () => "sub",
+          },
+        })
+        .getRoutes();
+
+      expect(getRouteRecordLocation(subRoutes.hoge, { id: "wow" })).toEqual({
+        pathname: "/wow/hoge",
+        state: null,
+      });
+    });
   });
 
   describe("exact route", () => {

diff --git a/src/builder/PathRouteBuilder/index.ts b/src/builder/PathRouteBuilder/index.ts
@@ -257,7 +257,7 @@ export class PathRouteBuilder<
     >
   >(
     key: Key,
-    routeDefinition: RD
+    routeDefinition?: RD
   ): PathRouteBuilder<
     ActionResult,
     Defs,
@@ -286,7 +286,7 @@ export class PathRouteBuilder<
         // TypeScript requires this `as` but this should be true because Key extends string.
         key as Extract<Key, string>,
         isString,
-        routeDefinition.action
+        routeDefinition?.action
       ),
     };
     return result;