Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery UI and Add Required Components #47

Closed
ehelms opened this issue Aug 21, 2012 · 10 comments
Closed

Remove jQuery UI and Add Required Components #47

ehelms opened this issue Aug 21, 2012 · 10 comments
Assignees
Milestone

Comments

@ehelms
Copy link
Contributor

ehelms commented Aug 21, 2012

Due to the overall size of jQuery UI and lack of usage of it's components it should be removed.

  • Progress Bar
  • Datepicker
  • Resizable
  • Dialog
@ghost ghost assigned ehelms Aug 21, 2012
@andyfitzsuse
Copy link
Contributor

We need a polyfill for both <input type="datetime" and <input type="date"

http://html5please.com/#date gives us two options

I'd like to suggest http://afarkas.github.com/webshim/demos/demos/webforms.html with our own custom css for the datepicker widget

https://github.com/zoltan-dulac/html5Forms.js/tree/master/shared/js looks fine but I haven't had the chance to test it.

Our javascript fallback for when we use input type="date" would use the noscript tag

<input type="date" />
<noscript> <small>Please enter DDMMYYYY (with no spaces)</small></noscript>

We will still have to do server validation of the input content

@ehelms
Copy link
Contributor Author

ehelms commented Aug 22, 2012

Progress Bar Candidate - http://t.wits.sg/misc/jQueryProgressBar/demo.php

@ehelms
Copy link
Contributor Author

ehelms commented Aug 22, 2012

@xsuchy
Copy link
Contributor

xsuchy commented Sep 4, 2012

jquery should be removed completly from converge-ui and let ship it as standalone package:
https://bugzilla.redhat.com/show_bug.cgi?id=805587

@ehelms
Copy link
Contributor Author

ehelms commented Sep 4, 2012

This is a separate issue you raise - but relying on the fact that an RPM of jQuery exists seems like it would cause more problems than it would solve.

@knowncitizen
Copy link
Contributor

I fully concur with Eric here. Putting a seemingly random version of jQuery that is updatable froma n RPM could cause major issues if the API changes.

@xsuchy
Copy link
Contributor

xsuchy commented Sep 4, 2012

You can enforce specific version using Requires:
Requires: jquery > 1.7.0
Requires: jquery < 1.8.0

@ehelms
Copy link
Contributor Author

ehelms commented Sep 4, 2012

That would only work on RPM based systems would it not? If we remove jQuery from here, then when you clone either Katello or Conductor, you would have to ensure that the jQuery RPM was installed, and make sure we have symlinks pointing to wherever that it gets installed so that our asset pipeline could find it for serving it up in development or production?

@ehelms
Copy link
Contributor Author

ehelms commented Nov 26, 2012

Created multiple smaller issues to discuss and deal with the parts mentioned here that need addressing before removal of jQuery UI:

Progress Bar - https://github.com/ui-alchemy/alchemy/issues/117
Datepicker - https://github.com/ui-alchemy/alchemy/issues/111
Resizeable - https://github.com/ui-alchemy/alchemy/issues/118
Dialog - https://github.com/ui-alchemy/alchemy/issues/119

@ehelms ehelms closed this as completed Mar 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants