-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery UI and Add Required Components #47
Comments
We need a polyfill for both http://html5please.com/#date gives us two options I'd like to suggest http://afarkas.github.com/webshim/demos/demos/webforms.html with our own custom css for the datepicker widget https://github.com/zoltan-dulac/html5Forms.js/tree/master/shared/js looks fine but I haven't had the chance to test it. Our javascript fallback for when we use input type="date" would use the noscript tag
We will still have to do server validation of the input content |
Progress Bar Candidate - http://t.wits.sg/misc/jQueryProgressBar/demo.php |
DatePicker Candidate - |
jquery should be removed completly from converge-ui and let ship it as standalone package: |
This is a separate issue you raise - but relying on the fact that an RPM of jQuery exists seems like it would cause more problems than it would solve. |
I fully concur with Eric here. Putting a seemingly random version of jQuery that is updatable froma n RPM could cause major issues if the API changes. |
You can enforce specific version using Requires: |
That would only work on RPM based systems would it not? If we remove jQuery from here, then when you clone either Katello or Conductor, you would have to ensure that the jQuery RPM was installed, and make sure we have symlinks pointing to wherever that it gets installed so that our asset pipeline could find it for serving it up in development or production? |
Created multiple smaller issues to discuss and deal with the parts mentioned here that need addressing before removal of jQuery UI: Progress Bar - https://github.com/ui-alchemy/alchemy/issues/117 |
Due to the overall size of jQuery UI and lack of usage of it's components it should be removed.
The text was updated successfully, but these errors were encountered: