Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Angular 16 support #589

Merged
merged 7 commits into from Aug 18, 2023
Merged

chore: Angular 16 support #589

merged 7 commits into from Aug 18, 2023

Conversation

boxmein
Copy link
Contributor

@boxmein boxmein commented Jun 29, 2023 •
edited

This PR implements Angular 16 support.

Once the sample app (ui-router/sample-app-angular-hybrid#914) is updated, this PR is also mergeable

Fixes #588

@boxmein boxmein changed the title fix: Angular 16 support chore: Angular 16 support Jun 29, 2023
@boxmein boxmein mentioned this pull request Jul 12, 2023
Closed
@boxmein
Copy link
Contributor Author

boxmein commented Jul 12, 2023

Taking care of ui-router/sample-app-angular-hybrid#913

@boxmein boxmein marked this pull request as ready for review July 13, 2023 09:54
@wawyed
Copy link
Member

wawyed commented Jul 14, 2023

hmm looks like the example is failing.

@wawyed
Copy link
Member

wawyed commented Jul 14, 2023

I figure it out, you need to update:

"webpack": "^5.77.0",
"webpack-cli": "^5.0.1",
"webpack-dev-server": "^4.13.2"

in the examples package.json

@boxmein
Copy link
Contributor Author

boxmein commented Jul 14, 2023

Thanks so much. If it's OK I will pick it up after my vacation, at the 2nd week of August.

@boxmein
Copy link
Contributor Author

boxmein commented Aug 16, 2023

Testing locally, with your recommended changes, the test:downstream NPM script started passing.

@boxmein boxmein requested a review from wawyed August 16, 2023 11:37
@wawyed
Copy link
Member

wawyed commented Aug 17, 2023

Hi, can you change the downstream test to uirouter I just merged it.

@boxmein
Copy link
Contributor Author

boxmein commented Aug 18, 2023

Thanks @wawyed, I'll take care of it.

@wawyed wawyed merged commit 02cb6e2 into ui-router:master Aug 18, 2023
4 checks passed
wawyed pushed a commit that referenced this pull request Aug 18, 2023
@boxmein @wawyed
feat: Angular 16 support (#589)
2293f30 
* preparation work for angular 16 support

* update to @uirouter/angular@12.0.0

* Update to ui-router/angular@12

* Temporarily point to the Angular 16 update PR

* update packages

* update rxjs

* change back to point to sample-app-angular-hybrid
@boxmein boxmein deleted the boxmein_588 branch August 20, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawyed wawyed Awaiting requested review from wawyed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for v16 in @uirouter/angular-hybrid
2 participants
@boxmein @wawyed