Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Angular 17 support #595

Merged
merged 1 commit into from Apr 8, 2024
Merged

Conversation

vanhorickanthony
Copy link
Contributor

This PR adds support for Angular v17.

Fixes #594.

@lievenjanssen
Copy link

@wawyed can this be merged or is there anything that still needs to be done?

@wawyed
Copy link
Member

wawyed commented Mar 11, 2024

@lievenjanssen test-downstream needs to be sorted out

@vanhorickanthony
Copy link
Contributor Author

@wawyed The downstream test fails because of incompatible peer dependencies between version 16 and 17 - you can however successfully run the tests locally by substituting the hybrid UI router dependency for the local version.
The tests currently use the latest released version which is still V16 - while the version being tested is V17.

@wawyed
Copy link
Member

wawyed commented Mar 11, 2024

You need to create a PR there such as ui-router/sample-app-angular-hybrid#914

@kburczyk
Copy link

@vanhorickanthony Thank you very much, for this update. I'm desperately waiting for it. Do you know, when it will be merged?

@vanhorickanthony
Copy link
Contributor Author

@wawyed Alright, thanks. A PR has been created as requested, and can be tracked here ui-router/sample-app-angular-hybrid#916.

@lievenjanssen
Copy link

@wawyed is the requested PR on the sample app ok? Is there anything still needed to move on with merging this?

@wawyed wawyed closed this Apr 8, 2024
@wawyed wawyed reopened this Apr 8, 2024
@wawyed
Copy link
Member

wawyed commented Apr 8, 2024

@wawyed is the requested PR on the sample app ok? Is there anything still needed to move on with merging this?

Just trying to figure out why is it failing now.

@wawyed wawyed merged commit 0e4e1da into ui-router:master Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for v17 in @uirouter/angular-hybrid
4 participants