Update Dependencies to Angular v14 #967

devlinjunker · 2022-07-20T21:54:01Z

Steps:

updated @angular libs
updated ng-packagr and created ng-package.json for packaging
updated jest and jest-preset-angular so tests pass

Tests Passing:

Build:

Notes

Should increment version to 10.0.0 after this and create a new release for NPM

- updated @angular libs - updated ng-packagr and created ng-package.json for packaging - updated jest and jest-preset-angular so tests pass

devlinjunker · 2022-07-20T21:55:56Z

@christopherthielen @oBusk any qualms with merging this and creating v10.0.0 release?

alaahl1 · 2022-08-07T07:24:15Z

Any ETA on this?

YanerTavuz · 2022-08-12T11:49:10Z

Got any updates on this? @christopherthielen @oBusk

wawyed · 2022-08-12T13:59:11Z

What is the reason for the creation of the ng-package.json?

wawyed · 2022-08-12T14:01:59Z

Also looks like the test are failing. Can you fix the missing dependency?

devlinjunker · 2022-08-12T15:34:16Z

What is the reason for the creation of the ng-package.json?

https://github.com/ng-packagr/ng-packagr now requires a separate ng-package.json file rather than including the details in the package.json (you can compare the current README to ng-packagr@v13

Also added dependency for @angular-devkit/build-angular, let see if it is building now

Thanks for your help @wawyed!

devlinjunker · 2022-08-12T17:13:09Z

hmm.. not sure what to do with the current error in the CI:

npx check-peer-dependencies
  shell: /usr/bin/bash -e {0}
  ✅  ajv ^8.0.0 is required by ajv-formats@2.1.1 (8.11.0 is installed)
  ❌  ajv ^6.9.1 is required by ajv-keywords@[3](https://github.com/ui-router/angular/runs/7809448440?check_suite_focus=true#step:5:3).[5](https://github.com/ui-router/angular/runs/7809448440?check_suite_focus=true#step:5:6).2) (8.11.0 is installed)
  ✅  ajv ^8.8.2 is required by ajv-keywords@5.1.0 (8.11.0 is installed)

dereekb · 2022-08-13T07:25:35Z

Looks like there are conflicting peer dependencies. Before you made that last change it was ok, but with the addition of dev kit it added some to yarn-lock:


"schema-utils@^2.6.5":
  "integrity" "sha512-SHiNtMOUGWBQJwzISiVYKu82GiV4QYGePp3odlY1tuKO7gPtphAT5R/py0fA6xtbgLL/RvtJZnU9b8s0F1q0Xg=="
  "resolved" "https://registry.npmjs.org/schema-utils/-/schema-utils-2.7.1.tgz"
  "version" "2.7.1"
  dependencies:
    "@types/json-schema" "^7.0.5"
    "ajv" "^6.12.4"
    "ajv-keywords" "^3.5.2"

"schema-utils@^3.1.0":
  "integrity" "sha512-Y5PQxS4ITlC+EahLuXaY86TXfR7Dc5lw294alXOq86JAHCihAIZfqv8nNCWvaEJvaC51uN9hbLGeV0cFBdH+Fw=="
  "resolved" "https://registry.npmjs.org/schema-utils/-/schema-utils-3.1.1.tgz"
  "version" "3.1.1"
  dependencies:
    "@types/json-schema" "^7.0.8"
    "ajv" "^6.12.5"
    "ajv-keywords" "^3.5.2"

"schema-utils@^3.1.1":
  "integrity" "sha512-Y5PQxS4ITlC+EahLuXaY86TXfR7Dc5lw294alXOq86JAHCihAIZfqv8nNCWvaEJvaC51uN9hbLGeV0cFBdH+Fw=="
  "resolved" "https://registry.npmjs.org/schema-utils/-/schema-utils-3.1.1.tgz"
  "version" "3.1.1"
  dependencies:
    "@types/json-schema" "^7.0.8"
    "ajv" "^6.12.5"
    "ajv-keywords" "^3.5.2"

"schema-utils@^4.0.0":
  "integrity" "sha512-1edyXKgh6XnJsJSQ8mKWXnN/BVaIbFMLpouRUrXgVq7WYne5kw3MW7UPhO44uRXQSIpTSXoJbmrR2X0w9kUTyg=="
  "resolved" "https://registry.npmjs.org/schema-utils/-/schema-utils-4.0.0.tgz"
  "version" "4.0.0"
  dependencies:
    "@types/json-schema" "^7.0.9"
    "ajv" "^8.8.0"
    "ajv-formats" "^2.1.1"
    "ajv-keywords" "^5.0.0"

There's nothing wrong with the peer dependencies though. Yarn doesn't report anything either. I'm not so sure that test is set up correctly. Looking at that package, I'd figure it should be set up as:

npx check-peer-dependencies --runOnlyOnRootDependencies

Which does pass. Can you modify the test to include that?

package.json

devlinjunker · 2022-08-18T22:18:01Z

I updated the check-peer-dependencies command and it looks like it is passing locally now

devlinjunker · 2022-08-19T17:38:27Z

oh.. I didn't realize the ci.yml file had it's own definition of the npx check-peer-dependencies, I updated that in my branch to include --runOnlyOnRootDependencies

But I guess I'm not sure if that or the master branch version of the workflow will be used

devlinjunker · 2022-08-22T22:11:03Z

can we approve the workflow again to see if it is fixed @dereekb @wawyed @christopherthielen ?

dereekb · 2022-08-23T00:55:48Z

I'm not a maintainer, but it looks good to me, fwiw. I have been using your branch on my Angular 14 projects already and haven't run into any issues.

devlinjunker · 2022-08-26T16:34:04Z

@wawyed think you can help out?

devlinjunker · 2022-09-07T20:48:51Z

@wawyed added angular v14 test project, hoping that should solve the ci errors now

devlinjunker · 2022-09-12T20:58:26Z

Found these instructions for updating Angular versions: https://github.com/ui-router/angular/blob/master/add_support_for_new_angular_version.txt

Pushed a commit to this PR after following these steps:

 - update tests in test-angular-versions/
   - ./scaffold.sh 11
   - remove old tests fro test-angular-versions and ../downstream_projects.json
 - update tests in test-typescript-versions/
   - ./scaffold.sh 4.5
   - (maybe) remove old tests fro test-typescript-versions and ../downstream_projects.json

Also created a PR in sample-app-angular as per the following instructions:

 - npx ng update @angular/core @angular/cli
 - git commit -m "chore: update to Angular 11"
 - yarn && yarn test
 - gh pr create

ui-router/sample-app-angular#771

After the PR is merged, I think the test:downstream job should not fail

wawyed · 2022-09-13T09:26:37Z

hmm.. not sure what to do with the current error in the CI:

npx check-peer-dependencies
  shell: /usr/bin/bash -e {0}
  ✅  ajv ^8.0.0 is required by ajv-formats@2.1.1 (8.11.0 is installed)
  ❌  ajv ^6.9.1 is required by ajv-keywords@[3](https://github.com/ui-router/angular/runs/7809448440?check_suite_focus=true#step:5:3).[5](https://github.com/ui-router/angular/runs/7809448440?check_suite_focus=true#step:5:6).2) (8.11.0 is installed)
  ✅  ajv ^8.8.2 is required by ajv-keywords@5.1.0 (8.11.0 is installed)

For this issue. I noticed something was done to be fixed here ui-router/sample-app-angular@3aad92b Maybe try this same approach?

wawyed · 2022-09-14T10:03:52Z

I guess we need to fix the mergify config in this project too

devlinjunker · 2022-09-14T19:25:35Z

created #968 to update mergify config

.github/workflows/ci.yml

package.json

devlinjunker · 2022-09-15T18:33:44Z

Looks like all CI is passing and I have updated to use the check-peer-dependencies.ignore property in package.json.

After this is merged, we will need to create a new release (v10.0.0 I would think), as per the instructions here:
https://github.com/ui-router/angular/blob/master/add_support_for_new_angular_version.txt#L19
(npm run release)

not sure if I can do this though... @wawyed

Once the release is made, I will begin to work on these steps to get https://github.com/ui-router/angular-hybrid updated to angular v14

wawyed · 2022-09-15T20:41:46Z

Looks like all CI is passing and I have updated to use the check-peer-dependencies.ignore property in package.json.

After this is merged, we will need to create a new release (v10.0.0 I would think), as per the instructions here: https://github.com/ui-router/angular/blob/master/add_support_for_new_angular_version.txt#L19 (npm run release)

not sure if I can do this though... @wawyed

Once the release is made, I will begin to work on these steps to get https://github.com/ui-router/angular-hybrid updated to angular v14

I'll look into it. I just realised I should have squashed the commits...

devlinjunker · 2022-09-16T17:09:30Z

@wawyed do you think you can force push to revert these changes and then I can create a PR again that we can squash?

Or is it alright that you didn't squash and we can move forward with the release of v10.0.0 now?

I am blocked on updating https://github.com/ui-router/angular-hybrid until the v10.0.0 ui-router/angular release is created

devlinjunker · 2022-09-19T18:31:41Z

@wawyed can you also create release artifacts for this repo and https://github.com/ui-router/angular-hybrid

and have you run npm publish in the repo with the newest version? (I think these steps should update the npm registry: https://docs.npmjs.com/updating-your-published-package-version-number)

wawyed · 2022-09-19T18:51:17Z

What do you mean both libraries should be at the latest version?

https://www.npmjs.com/package/@uirouter/angular-hybrid version 14
https://www.npmjs.com/package/@uirouter/angular version 10

updated to angular v14

10747da

- updated @angular libs - updated ng-packagr and created ng-package.json for packaging - updated jest and jest-preset-angular so tests pass

devlinjunker mentioned this pull request Jul 20, 2022

Update Dependencies to Angular v14 ui-router/angular-hybrid#571

Closed

devlinjunker mentioned this pull request Jul 29, 2022

Angular v14 support #964

Closed

add dependency

3b5d50c

dereekb reviewed Aug 13, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

update check-peer-depencies and angular-devkit version

f6b7de8

update ci.yml to use --runOnlyOnRootDependencies

c54c4ad

add angular v14 project

33ed421

devlinjunker mentioned this pull request Sep 12, 2022

Update for Angular v14 ui-router/sample-app-angular#771

Merged

following instructions to update tests

c0af4c8

devlinjunker mentioned this pull request Sep 12, 2022

Fixing Mergify Config ui-router/sample-app-angular-hybrid#894

Merged

update yarn.lock

ba9c004

devlinjunker commented Sep 14, 2022

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

devlinjunker commented Sep 14, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

Devlin Junker added 3 commits September 14, 2022 13:13

add link in contributing doc to updating angular version

f62e047

fix link

71b5736

add ignore to package.json for check-peer-dependencies

dbb534a

wawyed merged commit b6c3428 into ui-router:master Sep 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Dependencies to Angular v14 #967

Update Dependencies to Angular v14 #967

devlinjunker commented Jul 20, 2022 •

edited

devlinjunker commented Jul 20, 2022

alaahl1 commented Aug 7, 2022

YanerTavuz commented Aug 12, 2022

wawyed commented Aug 12, 2022

wawyed commented Aug 12, 2022

devlinjunker commented Aug 12, 2022 •

edited

devlinjunker commented Aug 12, 2022

dereekb commented Aug 13, 2022 •

edited

devlinjunker commented Aug 18, 2022

devlinjunker commented Aug 19, 2022

devlinjunker commented Aug 22, 2022

dereekb commented Aug 23, 2022

devlinjunker commented Aug 26, 2022

devlinjunker commented Sep 7, 2022

devlinjunker commented Sep 12, 2022

wawyed commented Sep 13, 2022

wawyed commented Sep 14, 2022

devlinjunker commented Sep 14, 2022

devlinjunker commented Sep 15, 2022 •

edited

wawyed commented Sep 15, 2022

devlinjunker commented Sep 16, 2022 •

edited

devlinjunker commented Sep 19, 2022

wawyed commented Sep 19, 2022

Update Dependencies to Angular v14 #967

Update Dependencies to Angular v14 #967

Conversation

devlinjunker commented Jul 20, 2022 • edited

Steps:

Notes

devlinjunker commented Jul 20, 2022

alaahl1 commented Aug 7, 2022

YanerTavuz commented Aug 12, 2022

wawyed commented Aug 12, 2022

wawyed commented Aug 12, 2022

devlinjunker commented Aug 12, 2022 • edited

devlinjunker commented Aug 12, 2022

dereekb commented Aug 13, 2022 • edited

devlinjunker commented Aug 18, 2022

devlinjunker commented Aug 19, 2022

devlinjunker commented Aug 22, 2022

dereekb commented Aug 23, 2022

devlinjunker commented Aug 26, 2022

devlinjunker commented Sep 7, 2022

devlinjunker commented Sep 12, 2022

wawyed commented Sep 13, 2022

wawyed commented Sep 14, 2022

devlinjunker commented Sep 14, 2022

devlinjunker commented Sep 15, 2022 • edited

wawyed commented Sep 15, 2022

devlinjunker commented Sep 16, 2022 • edited

devlinjunker commented Sep 19, 2022

wawyed commented Sep 19, 2022

devlinjunker commented Jul 20, 2022 •

edited

devlinjunker commented Aug 12, 2022 •

edited

dereekb commented Aug 13, 2022 •

edited

devlinjunker commented Sep 15, 2022 •

edited

devlinjunker commented Sep 16, 2022 •

edited