fix(vanilla): Fix baseHref parsing with chrome-extension:// urls

Closes #304
ui-router · Jan 28, 2019 · f11be4d · f11be4d
1 parent 148b16b
commit f11be4d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/vanilla/browserLocationConfig.ts b/src/vanilla/browserLocationConfig.ts
@@ -44,7 +44,7 @@ export class BrowserLocationConfig implements LocationConfig {
   private getBaseHref() {
     const baseTag: HTMLBaseElement = document.getElementsByTagName('base')[0];
     if (baseTag && baseTag.href) {
-      return baseTag.href.replace(/^(https?:)?\/\/[^/]*/, '');
+      return baseTag.href.replace(/^([^/:]*:)?\/\/[^/]*/, '');
     }
 
     return this._isHtml5 ? '/' : location.pathname || '/';

diff --git a/test/vanilla.browserLocationConfigSpec.ts b/test/vanilla.browserLocationConfigSpec.ts
@@ -128,6 +128,24 @@ describe('BrowserLocationConfig implementation', () => {
       expect(blc.baseHref()).toBe('/base');
     });
 
+    it('strips off the http origin', () => {
+      applyBaseTag('http://localhost/base');
+      const blc = new BrowserLocationConfig();
+      expect(blc.baseHref()).toBe('/base');
+    });
+
+    it('strips off the https origin', () => {
+      applyBaseTag('https://localhost/base');
+      const blc = new BrowserLocationConfig();
+      expect(blc.baseHref()).toBe('/base');
+    });
+
+    it('supports chrome-extension:// urls', () => {
+      applyBaseTag('chrome-extension://cckppebifaokhmbkciccdindfbmacjcj/baseHref/');
+      const blc = new BrowserLocationConfig();
+      expect(blc.baseHref()).toBe('/baseHref/');
+    });
+
     it('uses location.pathname if <base> is not present', () => {
       const blc = new BrowserLocationConfig();
       expect(blc.baseHref()).toBe(location.pathname);