Update PathUtils.treeChanges to retained nodes with to params applied #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgerstenblatt it appears that the retained states with new params are being treated as new states (via to). Since they have new params, they should be reloaded (unless reloadOnSearch is false). Will this affect that behavior? I'm not terribly familiar with this code, jumping in via the sticky states issue. 👍 for PR, fixes issues and is stable for me. |
|
@jnfeinstein I was able to find a fix without having to modify the ui-router core. Give this a spin: ui-router/sticky-states#15 |
|
@mgerstenblatt which is the more correct fix? |
|
@jnfeinstein I've been using the patched sticky-states version in my production app. You'll have to build the JS from that fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to address an issue in sticky-states (ui-router/sticky-states#13) where dynamic parameters were not working.
Updating PathUtils.treeChanges to return the retained nodes with the to parameters applied fixes the issue.