Make sure $state.href (and by extension uiSref) handle inherit: false

[oBusk]

Fixes #833

[wawyed]

Needs this fix applied https://github.com/ui-router/angular-hybrid/pull/574/files

[oBusk]

@wawyed should i copy that change to my fork?

[wawyed]

Yes please

[oBusk]

Pushed it @wawyed

[wawyed]

Might need this as well:

https://github.com/ui-router/angular/pull/967/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R86-R88

[oBusk]

@wawyed pushed 👍

[wawyed]

hmm I wonder why is still failing.

[wawyed]

Can you update the dependency @uirouter/publish-scripts to 2.6.0

[oBusk]

Looks like it's still failing 😞

Looks like it's installing some local version of core but expecting the real version?

https://github.com/ui-router/core/actions/runs/3895405050/jobs/6650689255#step:5:311

[wawyed]

Can you try adding to the ignore @uirouter/core ?

[wawyed]

Thank you

[oBusk]

Do you have any idea if this is going to come out in a patch any time soon @wawyed?

[wawyed]

New version has been released.

[Nirator78]

Hi @oBusk,
I have an AngularJS project to maintain, and I wanted to upgrade @uirouter/angularjs from version 1.0.30 to 1.1.0 and @uirouter/core from version 6.0.8 to 6.1.0. However, after this update, all ui-sref links no longer work. I understood that I need to set the inherit property to false. However, I don't know where to implement this without having to go through all my routes (is there a configuration available?).
Thank you in advance for your assistance.

[wawyed]

I'm not entirely sure how this change breaks your implementation... The inherit false property gets added to the state declaration on the params object

[Nirator78]

Hi @oBusk ,
Thank for your answer, i will give you much information. I don't really know how the change can break my code, but every ui-serf directive doesn't work, I give you an extract of my code:
<a href ui-sref="app.menu">Menu</a>

And that the declaration of my route in AngularJS:

import template from "./pages/list/menu.html";
import { MenuController } from "./pages/list/menu.controller";

export const MenuRoutes = [
    "$stateProvider", ($stateProvider) => {
        $stateProvider
            .state('app.menu', {
                url: 'menu',
                template: template,
                controller: MenuController,
                controllerAs: 'vm',
                data: {
                    title: "Menu"
                }
            })
    }
];

If I write manually the route in the url it's working but not if I click on my button.

EDIT: The problem is not on the inherit, sorry for the disagreement.