Added SUCCESS_TRANSITION #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawsumisu
commented
Jan 20, 2019
| @@ -26,7 +32,7 @@ function dispatch( | |||
| event: string, | |||
| store: Store<any>, | |||
| trans: Transition | |||
| ): TransitionHookFn { | |||
| ): () => void { | |||
There was a problem hiding this comment.
This method returns a function that takes in no params, so it's not really a TransitionHookFn. It could be the case the the transition that gets passed into this return function is the actual trans value to use rather than the one passed into the higher-order function, but I didn't feel like investigating that.
There was a problem hiding this comment.
Good point, I agree () => void is better type here
|
@elboman Does this pull request look reasonable to merge? |
|
Hey, thanks for the PR. Looks good, merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.