Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-Material List widgets buttons overwrites #177

Closed
6 tasks done
elbakerino opened this issue Mar 15, 2022 · 1 comment
Closed
6 tasks done

DS-Material List widgets buttons overwrites #177

elbakerino opened this issue Mar 15, 2022 · 1 comment
Labels
enhancement New feature or request material-ui About the material-ui design-system widget
Projects
Milestone

Comments

@elbakerino
Copy link
Member

elbakerino commented Mar 15, 2022

It should be possible to overwrite the button / configure the button style in list widgets.

Currently GenericList, SimpleList, Table Footer, DND-DropArea are using IconButton with a tooltip. This component should be replaced with a custom button component that can be styled/switched by schema & props - with support for IconButton and Button.

Some labels should add the "element-name" options to e.g. Add Item, should be similar to the DND nameOfBlock option in v0.2.3.

Currently only size can be styled for some widgets, this should be normalized and further options added together with the new button component.

  • button as icon with tooltip or button with text
  • button generic title + titles including element-name
  • [ ] overwrite with custom component (to e.g. use (Icon)ButtonWithConfirm as the delete buttons) decided its better to use "container component overwrites"
  • button styling
    • button size
    • button variant (text, outlined, contained)
    • [ ] button text color
    • button color
  • [ ] new custom callback props onAdd, onMove, onDelete / before-cb for each decided its better to use "container component overwrites"
@elbakerino elbakerino added enhancement New feature or request material-ui About the material-ui design-system widget labels Mar 15, 2022
@elbakerino elbakerino added this to To do in ui-schema via automation Mar 15, 2022
@elbakerino elbakerino added this to the v0.3.0 milestone Mar 19, 2022
elbakerino added a commit that referenced this issue Mar 23, 2022
migrate SimpleList, Table to ListButton and add new customization props
@elbakerino
Copy link
Member Author

Most options added in 0.3.0-beta.0, further adjustments may be necessary internally.

ui-schema automation moved this from To do to Done Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request material-ui About the material-ui design-system widget
Projects
ui-schema
  
Done
Development

No branches or pull requests

1 participant