TypeError at /admin/post_office/email/add/

[kakulukia]

/site-packages/post_office/admin.py in _format_value, line 38
'NoneType' object is not iterable

return ','.join([item for item in value]) 

I clicked on the add mail button inside the admin.
Django 1.11.2
Python 3.6.1
PostOffice 2.0.8

[selwin]

Could you please upgrade to the latest PyPI version (3.0.2) and see if this is still an issue?

[kakulukia]

shall i actually be able to create an email by hand? i think its totally okay to just remove the add button in the admin .. i could create a pull request for this easily

[selwin]

You should be able to. I don't see why we wouldn't want to allow users to create user via Django's admin interface.

…

On Jul 30, 2017, at 4:31 PM, kakulukia ***@***.***> wrote: shall i actually be able to create an email by hand? i think its totally okay to just remove the add button in the admin .. i could create a pull request for this easily — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[kakulukia]

Sorry, but the issue is still existing in 3.0.2:

/Users/andy/.virtualenvs/VFK_PORTAL-9ZY_FLJr/lib/python3.6/site-packages/post_office/admin.py in _format_value

super(CommaSeparatedEmailWidget, self).__init__(*args, **kwargs)
self.attrs.update({'class': 'vTextField'})
def _format_value(self, value):
    # If the value is a string wrap it in a list so it does not get sliced.
    if isinstance(value, six.string_types):
        value = [value, ]
    return ','.join([item for item in value]) 

Value is empty

[selwin]

The patch for this issue was merged in just today #195 and was released on PyPI as 3.0.3

[kakulukia]

i just upgraded my installation and currently pypi only lists 3.0.2 as the latest version .. will try again later .. cheers

[selwin]

Hi there, I checked PyPI and indeed 3.0.3 is not there, I probably made some mistake cutting that release. I'll try to make a release again tomorrow. Win~

…

On Mon, Jul 31, 2017 at 4:24 PM, kakulukia ***@***.***> wrote: i just upgraded my installation and currently pypi only lists 3.0.2 as the latest version .. will try again later .. cheers — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#193 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALg8k6xLBLR5k7HyA1_Fzjy63WR9n_jks5sTZ1egaJpZM4N8Nxh> .

[kakulukia]

just installed from source because im preparing another PR and can confirm that adding email works in 3.0.3
BUT what about adding a log entry by hand, does that actually make sense?