You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.
I have changed the callback order I expected from the didShowAnimated / didHideAnimated delegates in relation to the completion callbacks.
The call order of the completion handler and the didShowAnimated/didHideAnimated handler will be called in reverse order depending on the state of the animated flag.
So I changed your code, to call
willShowAnimated / willHideAnimated (This is ok)
completion (Line 431 / 492 of CocoaBar.swift)
didShowAnimate / didHideAnimated (This could be called before completion, depending on the animated flag passed in)
I raised this issue for the sake of symmetry and perhaps expected call order from client code.
Cheers,
Samson
The text was updated successfully, but these errors were encountered:
Hi Merrick,
This isn't as much an issue as feedback.
I have changed the callback order I expected from the didShowAnimated / didHideAnimated delegates in relation to the completion callbacks.
The call order of the completion handler and the didShowAnimated/didHideAnimated handler will be called in reverse order depending on the state of the animated flag.
So I changed your code, to call
I raised this issue for the sake of symmetry and perhaps expected call order from client code.
Cheers,
Samson
The text was updated successfully, but these errors were encountered: