Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

doShowAnimated and doHideAnimated delegate call order #19

Closed
samsonho opened this issue Aug 10, 2016 · 1 comment
Closed

doShowAnimated and doHideAnimated delegate call order #19

samsonho opened this issue Aug 10, 2016 · 1 comment

Comments

@samsonho
Copy link

Hi Merrick,

This isn't as much an issue as feedback.

I have changed the callback order I expected from the didShowAnimated / didHideAnimated delegates in relation to the completion callbacks.

The call order of the completion handler and the didShowAnimated/didHideAnimated handler will be called in reverse order depending on the state of the animated flag.

So I changed your code, to call

willShowAnimated / willHideAnimated (This is ok)
completion (Line 431 / 492 of CocoaBar.swift)
didShowAnimate / didHideAnimated (This could be called before completion, depending on the animated flag passed in)

I raised this issue for the sake of symmetry and perhaps expected call order from client code.

Cheers,
Samson

@msaps
Copy link
Member

msaps commented Aug 10, 2016

Hi Samson,

Thanks for pointing that out! I've now fixed the ordering in develop and will integrate it into the next release.

Cheers,
Merrick

@msaps msaps closed this as completed Aug 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants