Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabman lies bar under status bar #135

Closed
aerialcombat opened this issue Sep 1, 2017 · 5 comments
Closed

tabman lies bar under status bar #135

aerialcombat opened this issue Sep 1, 2017 · 5 comments

Comments

@aerialcombat
Copy link
Contributor

aerialcombat commented Sep 1, 2017

In a popular view hierarchy, such as that of Instagram's, a tab takes the place of Navigation Bar in order to show more content. When another view controller is pushed into the Navigation Controller, the navigation bar appears, taking the place of tab. When popped, navigation bar hides, and tab takes its place.

When tabman is inside a hidden navigation controller, its size should extend all the way to the status bar, like a navigation controller's navigation bar would. But instead, the tab lives under the status bar, leaving a very awkward look of floating somewhere in the middle. Like so
screen shot 2017-09-02 at 3 47 10 am

Ok. it looks like same thing happens even when not inside Navigation Controller

@aerialcombat aerialcombat changed the title tabman bar under status bar when inside hidden Navigation Controller tabman lies bar under status bar Sep 1, 2017
@aerialcombat
Copy link
Contributor Author

I tried embedBar function and kept getting attachedTabmanBar to be nil.

@aerialcombat
Copy link
Contributor Author

aerialcombat commented Sep 1, 2017

To fix this issue, being able to change the change Y origin in Appearance.layout would be great.

@msaps
Copy link
Member

msaps commented Sep 5, 2017

@aerialcombat yeah looks like this could be an enhancement for when the bar is visible in a UINavigationController with a hidden bar or no navigation bar at all. I'll get on it 👍

@msaps
Copy link
Member

msaps commented Sep 6, 2017

@aerialcombat this is now available as of 0.8.3 😄

@msaps msaps closed this as completed Sep 6, 2017
@msaps msaps added fixed and removed in progress labels Sep 6, 2017
@aerialcombat
Copy link
Contributor Author

Never got to say "thank you". I've only recently been able to sign on to github. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants