Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when call safeAreaLayoutGuide function with Jailbroken device #438

Merged
merged 4 commits into from
Sep 7, 2019

Conversation

nghiaphunguyen
Copy link
Contributor

No description provided.

@msaps
Copy link
Member

msaps commented Jul 13, 2019

@nghiaphunguyen thanks for the PR 😄 - what exactly causes this on Jailbroken devices??

@nghiaphunguyen
Copy link
Contributor Author

nghiaphunguyen commented Jul 13, 2019

@nghiaphunguyen thanks for the PR 😄 - what exactly causes this on Jailbroken devices??

Don't know exactly the root cause, i think some apis are missed on Jailbroken devices, we received many crashes from users so try to fix this. I think this can help to prevent coming issues from other developers so i create this pr :)

@sasojadrovski
Copy link

This might be the same issue as #449 that I opened yesterday. If everything looks good to you @msaps, maybe this should be merged and will see how it goes in regards to the crashes :)

@msaps msaps added this to the 2.6.0 milestone Sep 7, 2019
@msaps msaps merged commit ca10e86 into uias:master Sep 7, 2019
@msaps
Copy link
Member

msaps commented Sep 7, 2019

@nghiaphunguyen @sasojadrovski have merged and will release it as part of 2.6.0 - hopefully it will fix a few of the JB issues 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants