fix: Slider shows not centered initially with center: true

uikit · Dec 15, 2022 · d90b157 · d90b157
1 parent 9419e20
commit d90b157
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 - Fix height calculation for `box-sizing: border-box` on Accordion content
 - Fix error in console if image can't be loaded in Svg component with `stroke-animation: true`
 - Fix `scrollIntoView()` no longer considers elements with `position: clip` as scrollable parents
+- Fix Slider shows not centered initially with `center: true`
 
 ### Changed
 

diff --git a/src/js/mixin/slider.js b/src/js/mixin/slider.js
@@ -97,7 +97,7 @@ export default {
 
             if (!force && stack.length > 1) {
                 if (stack.length === 2) {
-                    this._transitioner.forward(Math.min(this.duration, 200));
+                    this._transitioner?.forward(Math.min(this.duration, 200));
                 }
 
                 return;
@@ -130,17 +130,10 @@ export default {
                 prev && trigger(prev, 'itemhidden', [this]);
                 trigger(next, 'itemshown', [this]);
 
-                return new Promise((resolve) => {
-                    requestAnimationFrame(() => {
-                        stack.shift();
-                        if (stack.length) {
-                            this.show(stack.shift(), true);
-                        } else {
-                            this._transitioner = null;
-                        }
-                        resolve();
-                    });
-                });
+                stack.shift();
+                this._transitioner = null;
+
+                requestAnimationFrame(() => stack.length && this.show(stack.shift(), true));
             });
 
             prev && trigger(prev, 'itemhide', [this]);