Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP SCSS conversion #261

Closed
wants to merge 5 commits into from
Closed

WIP SCSS conversion #261

wants to merge 5 commits into from

Conversation

anotherZero
Copy link

I put together some changes to work toward a sass/scss port.
I made a best guess with where to put some stuff, and because of the current directory structure I placed the theme scss in the same folder as the less. This may need to be looked at.
SCSS requires vars be defined before referenced, so some stuff probably still needs to be shuffled a bit. One problem I found was that normalize.less references @base-code-font-family while it is defined in the next @import base.less. This needs to be looked at.

TODO:

  • fix mixins/hooks
  • add !default flag to variables
  • add compile task
  • get variables defined before they are referenced (to be discovered after .hook-* refs are fixed)

partially addresses #260 interested in [official] SASS port of uikit

@m5o
Copy link

m5o commented Feb 3, 2014

Nice!

some advices:

A good resource for less regex is the converter/less_conversion.rb or the one at the vwall/compass-twitter-bootstrap gem

Compile scss with grunt-contrib-sass.

Great work so far!

@anotherZero
Copy link
Author

I'm happy to resend this pull request from another branch if uikit desires. I just worked in master because they currently have a complete lack of feature/release branches.

Also, Is this not a string literal? https://github.com/uikit/uikit/blob/master/src/less/icon.less#L53

@m5o
Copy link

m5o commented Feb 3, 2014

Also, Is this not a string literal? https://github.com/uikit/uikit/blob/master/src/less/icon.less#L53

You are absolutely right, sorry!

@anotherZero
Copy link
Author

@m5o

A good resource for less regex is the converter/less_conversion.rb

wow, that makes my ADHD flair up

@zslabs
Copy link

zslabs commented Mar 13, 2014

Great job, love that this is a possibility with Grunt!

@aheinze
Copy link
Member

aheinze commented Oct 13, 2014

there is an official Sass release since UIkit 2.11.

@aheinze aheinze closed this Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants