fix(ui): Upcoming events are shown again. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(ui): Events are shown again. The problem was caused by a parsing error of event descriptions with links in it. As a quick fix, the event description is not shown anymore. and the github action should work again. #57
Closed
|
Thank you!! Wonderful! I will forward your suggestion for future fixes and improvements to the community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(ui): Events are shown again. The problem was caused by a parsing error of event descriptions with links in it. As a quick fix, the event description is not shown anymore. and the github action should work again.
The "upcoming events shortcode" converts the vortex xml feed into a JSON using an API. The summary/description text was then extracted from the JSON. This worked fine unti one of the descriptions contained a link. Links are converted to nested levels of JSON. See image:
The shortcode was unable to "plainify" this nested JSON and crashed. As a quick fix, I have removed the description from the output.
A proper fix would be to filter the nested "p" structure for all "text" fields and paste them together.
The code is commented out, in case anyone wants to dive into Hugo and figure out how to do this later. I currently have no capacity for it.
Itnow looks like this:
fixes #57