Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card container queries #922

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Card container queries #922

merged 12 commits into from
Apr 2, 2024

Conversation

bspeare
Copy link
Contributor

@bspeare bspeare commented Mar 25, 2024 •
edited
Loading

Resolves uiowa/uiowa#4678

How to test

  • Code review
  • yarn storybook
  • Go to http://localhost:6006/?path=/story/components-card--grid-3-columns
    • Test card orientation using Safari's responsive design mode (Develop > Enter responsive design mode) observe left/right aligned cards adjust to stacked
    • Test image style and size
      • Widescreen, square, circle
      • Small, medium, large
    • Test with and without background color
    • Test with and without card border

@bspeare bspeare mentioned this pull request Mar 27, 2024
Closed
@bspeare bspeare marked this pull request as ready for review March 27, 2024 18:38
@bspeare bspeare requested a review from a team March 27, 2024 18:38
@bspeare bspeare added the uids label Mar 27, 2024
@pyrello pyrello self-assigned this Mar 29, 2024
@pyrello
Copy link
Contributor

pyrello commented Mar 29, 2024

Pulling to test.

pyrello
pyrello approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@pyrello pyrello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

@pyrello pyrello merged commit 4d2c977 into 4.x Apr 2, 2024
2 checks passed
@pyrello pyrello deleted the container_queries_card branch April 2, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrello pyrello pyrello approved these changes

Assignees

@pyrello pyrello

Labels
uids
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card block titles overflow below the container breakpoint
2 participants
@bspeare @pyrello