[Card] Adjusted styles for media--date #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bspeare
changed the title
GaryRidgway
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Tested and looks good to me!
Something to keep in mid for the future is that it seems like the thinness of roboto on the black background may make it slightly harder to read on higher resolution monitors. Perhaps we should adjust the -webkit-font-smoothing property for this?
|
@GaryRidgway good question on the font smoothing. Feel free to push up an adjustment to the font smoothing on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
element-invisibleclass to<div class="media--date">and spacing should remain the same, the media slot should not collapse.