PHP 8.1 Upgrade

[joewhitsitt]

Relates to #5315
Resolves #5708

To do

History

• profiles/custom/sitenow @joewhitsitt
• themes/custom/uids_base @pyrello
• modules/custom/engineering_migrate
• modules/custom/grad_custom @pyrello
• modules/custom/layout_builder_custom @pyrello
• modules/custom/sitenow_articles @joewhitsitt
• modules/custom/sitenow_dcv @joewhitsitt - no changes
• modules/custom/sitenow_dispatch @joewhitsitt
• modules/custom/sitenow_events @joewhitsitt
• modules/custom/sitenow_find_text @joewhitsitt - no changes
• modules/custom/sitenow_intranet @joewhitsitt - no changes
• modules/custom/sitenow_media_wysiwyg @joewhitsitt
• modules/custom/sitenow_migrate @joewhitsitt
• modules/custom/sitenow_p2lb @joewhitsitt
• modules/custom/sitenow_pages
• modules/custom/sitenow_paragraphs @joewhitsitt
• modules/custom/sitenow_people @joewhitsitt
• modules/custom/sitenow_seo @joewhitsitt - no changes
• modules/custom/studentlife_migrate @joewhitsitt - no changes
• modules/custom/studentlife_topics @joewhitsitt - no changes
• modules/custom/uiowa_aggregator @joewhitsitt
• modules/custom/uiowa_alerts @joewhitsitt
• modules/custom/uiowa_apr @joewhitsitt - no changes
• modules/custom/uiowa_area_of_study @joewhitsitt
• modules/custom/uiowa_book @joewhitsitt - no changes
• modules/custom/uiowa_core @joewhitsitt
• modules/custom/uiowa_entities @joewhitsitt
• modules/custom/uiowa_graph @joewhitsitt
• modules/custom/uiowa_hours @joewhitsitt
• modules/custom/uiowa_maui @joewhitsitt
• modules/custom/uiowa_profiles @joewhitsitt
• modules/custom/uiowa_search @joewhitsitt - no changes
• modules/custom/writinguniversity_migrate @joewhitsitt - no changes
• modules/uiowa/uiowa_auth @joewhitsitt - uiowa_auth comparison update uiowa_auth#6
• sites/admissions.uiowa.edu @joewhitsitt
• sites/brand.uiowa.edu @joewhitsitt
• sites/coronavirus.uiowa.edu @joewhitsitt
• sites/dentistry.uiowa.edu @joewhitsitt
• sites/grad.admissions.uiowa.edu @joewhitsitt
• sites/grad.uiowa.edu @joewhitsitt
• sites/housing.uiowa.edu @joewhitsitt - no changes
• sites/hr.uiowa.edu @joewhitsitt
• sites/ighn.international.uiowa.edu @joewhitsitt
• sites/iisc.uiowa.edu @joewhitsitt
• sites/neuroscience.grad.uiowa.edu @joewhitsitt - no changes
• sites/now.uiowa.edu @joewhitsitt
• sites/pharmacy.uiowa.edu @joewhitsitt
• sites/sitenow.uiowa.edu - @GaryRidgway
• sites/sppa.uiowa.edu - @GaryRidgway
• sites/tippie.uiowa.edu - @GaryRidgway
• sites/transportation.uiowa.edu - @GaryRidgway
• sites/uiowa.edu - @GaryRidgway
• sites/uipress.uiowa.edu - @GaryRidgway

Please track any migration comparison operators of old migrations here:
#5708

Setup

It is recommended that your Docker and DDEV are updated:

• For docker, click the menu bar icon to download and install an update.
• brew upgrade ddev if you installed via homebrew

To Test

• pull
• ddev restart
• ddev composer install
• ddev auth ssh
• ddev ssh
• php -v and confirm 8.1 or greater

More Testing

• Generally take a look through this guide to see the types of things that are changing: https://www.php.net/manual/en/migration80.php
• Review the file changes to see if anything sticks out to you: https://github.com/uiowa/uiowa/pull/5611/files
• Review menu block as it relates to https://github.com/uiowa/uiowa/pull/5611/files#diff-22455fd1cfa159b58a0289784a91064192c27738f06b23e252be3a46271afb4cR609
• Review replicate as it relates to https://github.com/uiowa/uiowa/pull/5611/files#diff-96158dc2654c9de7f8206491f115c59eec3097e39643d343a870e538e89e5d6fR190
• Review v2/v3 functionality as it relates to the display title, hide headline, more link, use pager, link directly to source boolean options.
• Review that things previously restricted to Admins only are still working (they all use the same access check) so check to see that the advanced fontawesome icon options aren't visible to webmasters on event/timeline block.
• Make sure MAUI API is still sorting dates correctly based on timestamp.
• Check that there are no php errors while poking around law.dev, grad.dev or admissions.dev.

Semi-related, homebrew users should brew install php@8.1 on their machines and switch to it at some point.
Afterward, update your PHPStorm > Preferences > PHP > CLI Interpreter

[joewhitsitt]

Going to try switching to jammy for PHP 8.1

[joewhitsitt]

neutron/temporary-filesystem         2.4    requires  php (^5.6 || ^7.0)    
php-ffmpeg/php-ffmpeg                v0.14  requires  php (^5.3.9 || ^7.0)  
richardbporter/drush-users-commands  3.0.2  requires  php (^7.4)

[joewhitsitt]

@pyrello do you know if this is still needed?

https://github.com/uiowa/uiowa/blob/main/docroot/modules/custom/uiowa_search/composer.json

[pyrello]

@pyrello do you know if this is still needed?

https://github.com/uiowa/uiowa/blob/main/docroot/modules/custom/uiowa_search/composer.json

I think this is an artifact of when it was a standalone repo. I don't think it's needed anymore.

[joewhitsitt]

yay, travis went farther. running into this now: #5315 (comment)

[pyrello]

I think we need to merge in #5625 either to main or specifically to this branch to make sure we are getting all the correct composer dependency versions.

[pyrello]

It looks like the version of phpstan/phpdoc-parser in #5625 is set to 1.8, which is not compatible with everything else. When merging in #5625 and resolving conflicts in composer.lock, accept the changes for phpstan/phpdoc-parser in this branch. Otherwise, you're going to be in composer incompatible dependency hell.

[joewhitsitt]

The #blt Drupal Slack channel helped again. This is now properly auto deploying to DEV. Moving forward with upgrading to php 8.1. This PR is ready for review.

[pyrello]

Pulling this to start testing it

[pyrello]

Updated testing instructions: ddev restart has to happen prior to ddev composer install because of composer PHP constraint added to composer.json.

[pyrello]

I have reviewed all file changes and this is good to go from that perspective.

[pyrello]

Review that things previously restricted to Admins only are still working (they all use the same access check) so check to see that the advanced fontawesome icon options aren't visible to webmasters on event/timeline block.

@joewhitsitt What I am seeing is that the advanced options are visible but greyed out. Is that what is intended?

[joewhitsitt]

Correct. Additional Font Awesome Settings fields should be disabled

[pyrello]

I found two issues while testing:

• List block headlines were not honoring the "visually hide title" setting
• Replicate was broken because of the check to prevent deleting the current node.

I fixed both issues.

[pyrello]

After reviewing and testing this update both locally and on dev, I think that it looks good.