Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dompdf security fix #7471

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Dompdf security fix #7471

merged 3 commits into from
Mar 19, 2024

Conversation

joewhitsitt
Copy link
Contributor

@joewhitsitt joewhitsitt commented Mar 15, 2024

Resolves #7454

To Test

@joewhitsitt joewhitsitt requested a review from a team March 15, 2024 19:48
@joewhitsitt joewhitsitt marked this pull request as ready for review March 15, 2024 19:52
@joewhitsitt
Copy link
Contributor Author

I did test this as part of the issue. Basically looking for a second set of eyes on checking pdf diffs (if any).

@pyrello
Copy link
Contributor

pyrello commented Mar 19, 2024

Pulling to test.

@pyrello pyrello self-assigned this Mar 19, 2024
Copy link
Contributor

@pyrello pyrello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested 3 PDFs and could discern no differences. Thanks for the easy test instructions!

@pyrello pyrello merged commit 2c49b1a into main Mar 19, 2024
2 checks passed
@pyrello pyrello deleted the dompdf_security_fix branch March 19, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dompdf and security checks
2 participants