Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Problem
I think I did a mistake when I tested the lib on my previous PR about updating to Angular 14 #379.
What I did was:
Angular 13
on anAngular 13
demo appAngular 14
on anAngular 14
demo appWhat I did not:
Angular 14
on anAngular 13
demo appAnd it seems that using a compiled version of the lib with
Angular 14
isn't compatible with anAngular 13
app.Changes
This PR does:
Other solution
Another solution could be to compile the lib with
Angular 13
but still supportAngular 14
(^13.0.0 || ^14.0.0
), but I did not test it. If you wish, I can test it tomorrow. The down side would be to have anAngular 13
version of the repo on another branche. Maybe there's another solution, I'm not familiar enough with compiled version compatibility of libs.I'm sorry, I wasn't expecting that behavior 😢.
I don't know what's the best solution, remove the current 6.0 and make a new one or bump to 6.1 (or any version you want).
Have a good day/night.
@santoshyadavdev