Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only support Angular 14 #386

Merged
merged 2 commits into from
Aug 26, 2022
Merged

chore: only support Angular 14 #386

merged 2 commits into from
Aug 26, 2022

Conversation

Yberion
Copy link
Contributor

@Yberion Yberion commented Aug 26, 2022

Hello,

Problem

I think I did a mistake when I tested the lib on my previous PR about updating to Angular 14 #379.

What I did was:

  • Testing the lib compiled with Angular 13 on an Angular 13 demo app
  • Testing the lib compiled with Angular 14 on an Angular 14 demo app

What I did not:

  • Testing the lib compiled with Angular 14 on an Angular 13 demo app

And it seems that using a compiled version of the lib with Angular 14 isn't compatible with an Angular 13 app.

TypeError: Cannot create property 'message' on string 'D:\GitHub\Angular13Project\node_modules\@ngu\carousel\fesm2015\ngu-carousel.mjs: This application depends upon a library published using Angular version 14.1.3, which requires Angular version 14.0.0 or newer to work correctly.
Consider upgrading your application to use a more recent version of Angular.
  82 | }
  83 | NguCarouselItemDirective.ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "14.1.3", ngImport: i0, type: NguCarouselItemDirective, deps: [], target: i0.ɵɵFactoryTarget.Directive });
> 84 | NguCarouselItemDirective.ɵdir = i0.ɵɵngDeclareDirective({ minVersion: "14.0.0", version: "14.1.3", type: NguCarouselItemDirective, selector: "[NguCarouselItem]", ngImport: i0 });
     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^39m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^39m^^^^^^^^^^^^^^^^^^^

Changes

This PR does:

  • Only support Angular 14

Other solution

Another solution could be to compile the lib with Angular 13 but still support Angular 14 (^13.0.0 || ^14.0.0), but I did not test it. If you wish, I can test it tomorrow. The down side would be to have an Angular 13 version of the repo on another branche. Maybe there's another solution, I'm not familiar enough with compiled version compatibility of libs.

I'm sorry, I wasn't expecting that behavior 😢.
I don't know what's the best solution, remove the current 6.0 and make a new one or bump to 6.1 (or any version you want).

Have a good day/night.

@santoshyadavdev

@santoshyadavdev
Copy link
Member

santoshyadavdev commented Aug 26, 2022

@Yberion
Copy link
Contributor Author

Yberion commented Aug 26, 2022

Hello @santoshyadavdev, I've updated both readme.

Thanks for the fast answer!

Copy link
Member

@santoshyadavdev santoshyadavdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@santoshyadavdev santoshyadavdev merged commit c582403 into uiuniversal:master Aug 26, 2022
@santoshyadavdev
Copy link
Member

use 6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants