Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Angular 15 #398

Merged
merged 6 commits into from
Dec 15, 2022
Merged

chore: update to Angular 15 #398

merged 6 commits into from
Dec 15, 2022

Conversation

Yberion
Copy link
Contributor

@Yberion Yberion commented Dec 2, 2022

Hello,

This PR does:

  • Update to latest Angular 14 packages
  • Update all packages to latest version except:
    • typescript
    • @types/node
  • Update the lib to only support Angular ^15
  • Update the app to Angular 15
    • browserlistrc was removed
      • I had to run npx browserslist --update-db to update caniuse-lite
    • environment files have been deleted
      • angular.json was update to reflect that
  • I added scss files in the prettier
  • Use the experimental esbuild
    • @angular-devkit/build-angular:browser to @angular-devkit/build-angular:browser-esbuild

Feel free to also remove other PR/branche related to packages update for cleaning purpose.

If everything is ok, I can make a new commit to bump the version.
Could you release a new version following this PR? (This would be much appreciated heh)

Have a good day.

cc @santoshyadavdev

@santoshyadavdev
Copy link
Member

Nice, thank you for the PR @Yberion. Will review it soon.

Copy link
Member

@santoshyadavdev santoshyadavdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just want to know why we are using legacy material component

@@ -1,8 +1,8 @@
import { LayoutModule } from '@angular/cdk/layout';
import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
import { MatButtonModule } from '@angular/material/button';
import { MatLegacyButtonModule as MatButtonModule } from '@angular/material/legacy-button';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to use mdc based components? I know we don't provide CSS out of the box, but may break the user app if they have some :ng-deep

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is harder for people to migrate to MDC as it require quite a lot of CSS update.
If people were customizing your components, it would be easier for them if you don't switch for MDC yet.
Maybe you can do 2 versions, one without MDC (7.0.0) and one with MDC (7.1.0) ?

Up to you, do I migrate this PR to use MDC?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in next PR

@santoshyadavdev santoshyadavdev merged commit fd24c47 into uiuniversal:master Dec 15, 2022
@Yberion Yberion deleted the feature/angular-15 branch December 15, 2022 22:26
@Yberion
Copy link
Contributor Author

Yberion commented Dec 15, 2022

Awesome, I will prepare the MDC PR.

@santoshyadavdev
Copy link
Member

BTW just release V7 with Angular 15 changes

@Yberion
Copy link
Contributor Author

Yberion commented Dec 15, 2022

Yeah I noticed, thank you for that 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants