FIX: content duplication on async carousels #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a3b7f50. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Thank you for the PR |
santoshyadavdev
approved these changes
May 30, 2023
|
Adds @luca-peruzzo as a contributor for code. |
|
@all-contributors please add @luca-peruzzo for code |
|
I've put up a pull request to add @luca-peruzzo! 🎉 |
santoshyadavdev
pushed a commit
that referenced
this pull request
May 30, 2023
Adds @luca-peruzzo as a contributor for code. This was requested by santoshyadavdev [in this comment](#458 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
@santoshyadavdev When do you think this fix will be released? |
chivesrs
added a commit
to chivesrs/ngu-carousel
that referenced
this pull request
Jun 9, 2023
This reverts commit a42bb10.
chivesrs
added a commit
to chivesrs/ngu-carousel
that referenced
this pull request
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous version when the dataSource input was async and had an element count less than the displayed grid, there was a duplication of elements (you can test it with your example app, setting take(3) to tile.component.ts in a viewport that supports 5 tiles).