revert: "fix: optimizing useCodeMirror rendering issues. (#474)"

This reverts commit 5eee5f4.
uiwjs · Mar 25, 2023 · 2fbfc8f · 2fbfc8f
1 parent 952423f
commit 2fbfc8f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/src/index.tsx b/core/src/index.tsx
@@ -113,7 +113,7 @@ const ReactCodeMirror = forwardRef<ReactCodeMirrorRef, ReactCodeMirrorProps>((pr
   } = props;
   const editor = useRef<HTMLDivElement>(null);
   const { state, view, container } = useCodeMirror({
-    container: editor.current ? editor.current : undefined,
+    container: editor.current,
     root,
     value,
     autoFocus,

diff --git a/core/src/useCodeMirror.ts b/core/src/useCodeMirror.ts
@@ -10,7 +10,7 @@ import { ReactCodeMirrorProps } from '.';
 const External = Annotation.define<boolean>();
 
 export interface UseCodeMirror extends ReactCodeMirrorProps {
-  container?: HTMLDivElement;
+  container?: HTMLDivElement | null;
 }
 
 export function useCodeMirror(props: UseCodeMirror) {
@@ -147,7 +147,7 @@ export function useCodeMirror(props: UseCodeMirror) {
     };
   }, [container, state]);
 
-  useEffect(() => setContainer(props.container), [props.container]);
+  useEffect(() => setContainer(props.container!), [props.container]);
 
   useEffect(
     () => () => {