Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle with margin #142

Open
FlorianBEME opened this issue Feb 19, 2024 · 8 comments
Open

Circle with margin #142

FlorianBEME opened this issue Feb 19, 2024 · 8 comments

Comments

@FlorianBEME
Copy link

Hello there,

Using your library, I see that a margin has slipped around the circles. Is this a normal behavior? Do you know how I can center them? Is there a prop to add CSS classes (or styles) to override the style of the colored circles?

Thank you in advance and have a great day =D

Capture d’écran 2024-02-19 à 16 05 23

@jaywcjlove
Copy link
Member

@FlorianBEME

<Circle rectProps={{ className: 'name' }} />

@FlorianBEME
Copy link
Author

FlorianBEME commented Feb 23, 2024

I thank you for your response; Perhaps something is escaping me, however, I have the impression that the className does not apply to the correct HTML tag.

Capture d’écran 2024-02-23 à 11 24 45

Capture d’écran 2024-02-23 à 11 25 34
Capture d’écran 2024-02-23 à 11 25 24

jaywcjlove added a commit that referenced this issue Feb 23, 2024
github-actions bot pushed a commit that referenced this issue Feb 23, 2024
@jaywcjlove
Copy link
Member

I added a class name to it. @FlorianBEME

image

@FlorianBEME
Copy link
Author

First, I thank you for taking the time to address the issue ^^.
However, it seems that the div you pointed out is not the one with this margin.

It appears that this 12px margin is applied within the 'style' section. The issue is that if I try to override these properties, the content of the 'style' section seems to take priority.
Capture d’écran 2024-02-23 à 14 49 25

It might be wiser to create a 'pointProps' prop where we could pass the elements in a similar way as 'rectProp,' allowing us to override the style more effectively.

regardless, thank you for taking the time to respond to me.

@jaywcjlove
Copy link
Member

@FlorianBEME I accepted your advice. Upgrade v2.1.0

github-actions bot pushed a commit that referenced this issue Feb 23, 2024
@cyz1901
Copy link

cyz1901 commented Mar 3, 2024

@jaywcjlove sorry i have a small problem. Using it this way seems to overwrite all styles. I only want to override the specified styles.

    pointProps={{
        style: {
          marginBottom: 0,
        },
      }}

jaywcjlove added a commit that referenced this issue Mar 3, 2024
jaywcjlove added a commit that referenced this issue Mar 3, 2024
@jaywcjlove
Copy link
Member

@cyz1901 Upgrade v2.1.1

github-actions bot pushed a commit that referenced this issue Mar 3, 2024
@cyz1901
Copy link

cyz1901 commented Mar 9, 2024

thx lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants