Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browserslist "not dead" from package.json in v3.3.3 #449

Open
saran13raj opened this issue Oct 31, 2022 · 5 comments
Open

Remove browserslist "not dead" from package.json in v3.3.3 #449

saran13raj opened this issue Oct 31, 2022 · 5 comments

Comments

@saran13raj
Copy link

saran13raj commented Oct 31, 2022

Hi @jaywcjlove, we are restricted to use v3.3.3 because of react version and loader issues.
But when we make a build of our CRA app we get into a build error caused by borwserslist

ERROR in ./node_modules/@uiw/react-md-editor/lib/esm/components/Toolbar/index.css (./node_modules/css-loader/dist/cjs.js??ref--5-2!./node_modules/postcss-loader/src??ref--5-3!./node_modules/@uiw/react-md-editor/lib/esm/components/Toolbar/index.css)
    Module build failed (from ./node_modules/postcss-loader/src/index.js):
    BrowserslistError: Unknown browser query `dead`

We found that removing "not dead" from browsers list fixed the issue.
Can we remove "browserslist": {} from package.json for this specific version or you could create a patch version fix for this?

@saran13raj saran13raj changed the title Remove browserslist "not dead" config in v3.3.3 Remove browserslist "not dead" from package.josn in v3.3.3 Oct 31, 2022
@saran13raj saran13raj changed the title Remove browserslist "not dead" from package.josn in v3.3.3 Remove browserslist "not dead" from package.json in v3.3.3 Oct 31, 2022
@jaywcjlove
Copy link
Member

@saran13raj upgrade v3.19.4

@saran13raj
Copy link
Author

saran13raj commented Oct 31, 2022

As I said in the previous comment we are restricted to use v3.3.3 because of our existing repo's React version. Any version installed beyond v3.3.3 will not work. @jaywcjlove

@jaywcjlove
Copy link
Member

Published versions on npm cannot be modified

@saran13raj Maybe add configuration override browserslist in package.json

I can't reproduce your error.

@saran13raj
Copy link
Author

@jaywcjlove I understand that published versions can't be modified.
Configuration override for browserslist can't be done in this case because we're trying to override a config for a dependency package.
All I'm asking is can you release a new patch version v3.3.8 with browserslist removed?

@jaywcjlove
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants