-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type of height is string. #469
Comments
@0xMALVEE Upgrade |
thank you for fixing it |
@jaywcjlove now I am getting error when passing percentage string 🤔 |
Agreed, there should be a string option to pass in a percentage. |
Yes the height prop should be typed as string | number to also allow percentage values |
react-md-editor/core/src/Editor.tsx Lines 35 to 38 in ae53d0d
@0xMALVEE @thomasdohyunkim @TimAufdemKampe After testing the original type declaration is allowed to pass numbers and strings, so... |
type of the prop height is a string.
but it should be a number.
when using typescript it gives an error.
fix it
The text was updated successfully, but these errors were encountered: