Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type of height is string. #469

Closed
0xMALVEE opened this issue Dec 30, 2022 · 6 comments
Closed

type of height is string. #469

0xMALVEE opened this issue Dec 30, 2022 · 6 comments

Comments

@0xMALVEE
Copy link

type of the prop height is a string.
but it should be a number.
when using typescript it gives an error.
fix it

jaywcjlove added a commit that referenced this issue Dec 31, 2022
jaywcjlove added a commit that referenced this issue Dec 31, 2022
@jaywcjlove
Copy link
Member

@0xMALVEE Upgrade v3.20.2

@0xMALVEE
Copy link
Author

thank you for fixing it

@dkryaklin
Copy link

@jaywcjlove now I am getting error when passing percentage string 🤔

@thomasdohyunkim
Copy link

Agreed, there should be a string option to pass in a percentage.

@TimAufdemKampe
Copy link

Yes the height prop should be typed as string | number to also allow percentage values

jaywcjlove added a commit that referenced this issue Apr 27, 2023
@jaywcjlove
Copy link
Member

* The height of the editor.
* ⚠️ `Dragbar` is invalid when **`height`** parameter percentage.
*/
height?: CSSProperties['height'];

@0xMALVEE @thomasdohyunkim @TimAufdemKampe

After testing the original type declaration is allowed to pass numbers and strings, so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants