Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pens leader board using the data from Pens::Model #2261

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ujh
Copy link
Owner

@ujh ujh commented Jun 13, 2024

No description provided.

@ujh ujh force-pushed the better-pens-leader-board branch from f07da98 to 7ef3788 Compare June 13, 2024 10:57
@ujh ujh force-pushed the better-pens-leader-board branch from 7ef3788 to a26a218 Compare June 13, 2024 11:03
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.02%. Comparing base (8cbb523) to head (a26a218).

Files Patch % Lines
app/models/leader_board.rb 20.00% 4 Missing ⚠️
app/models/leader_board_row/pen_models.rb 0.00% 2 Missing ⚠️
app/models/pens/model.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
- Coverage   68.12%   68.02%   -0.10%     
==========================================
  Files         268      269       +1     
  Lines        4446     4454       +8     
  Branches      157      157              
==========================================
+ Hits         3029     3030       +1     
- Misses       1401     1408       +7     
  Partials       16       16              
Flag Coverage Δ
javascript 46.69% <ø> (ø)
ruby 80.91% <41.66%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ujh ujh merged commit 76b09c2 into master Jun 13, 2024
2 of 4 checks passed
@ujh ujh deleted the better-pens-leader-board branch June 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant