Add ability to declare output ImageCaptureTargetSize #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujizin
reviewed
Apr 20, 2023
There was a problem hiding this comment.
Hi @chrisHoekstra! I have completed the code review and have a few points that I'd like to discuss with you.
Thanks a lot for submitting this pull request! Well done!
This allows an autogenerated `equals` function to be used instead of hand comparing each individual value (or writing an `equals` function).
ujizin
approved these changes
Apr 21, 2023
|
@ujizin thank you so much for the quick review on this! |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need control over the size of the image the camera creates, so I added a configuration that allows this customization.