Version Updates #39
Version Updates #39
Conversation
Gradle to 8.5 Kotlin to 1.9.10 (dokka is incompatible with 1.9.21 at the moment) AGP to 8.2 AndroidX Core to 1.12 CameraX to 1.3.1 Compose to 2023.10.01
There was a problem hiding this comment.
Hey! First of all thanks so much for supporting Camposer 🙏
I reviewed some points here that's affecting the library and sample app.
There's another one, If possible could you please update the compilerSdk and targetSdk to 34? Otherwise the library won't compile
Later, I'll update the video feature and bump the cameraX version.
Thanks again! Have a good weekend 😄
gradle/libs.versions.toml
Outdated
| coil = "2.2.2" | ||
| androidx-core = "1.12.0" | ||
| androidx-test-rules = "1.5.0" | ||
| camerax = "1.3.1" |
There was a problem hiding this comment.
There're some breaking changes on video feature in this version that needs to resolve 😢
I will try to check this later, but please feel free to resolve or rollback to 1.2.3 again 😄
There was a problem hiding this comment.
I see you opened up a PR to address this. I rolled back the version here, but lmk if you want me to keep it bumped for easier merging into your branch
There was a problem hiding this comment.
Hi! Thanks for clarifying things for me!
I've updated, and soon I'll create a new release with our changes. Thanks for your contributions and patience on this.
gradle/libs.versions.toml
Outdated
| androidx-test-rules = "1.5.0" | ||
| camerax = "1.3.1" | ||
| compose-bom = "2023.10.01" | ||
| compose-compiler = "1.5.6" |
There was a problem hiding this comment.
Forgot about this one. The compiler needs to be 1.5.3 because of the kotlin compat
ref: https://developer.android.com/jetpack/androidx/releases/compose-kotlin
There was a problem hiding this comment.
Ah, missed that (I updated this first and then realized I needed to keep Kotlin at 1.9.10 due to dokka but didn't change the compiler version to accomodate)
Gradle to 8.5 (using
./gradlew wrapper --gradle-version=8.5)Kotlin to 1.9.10 (dokka is incompatible with 1.9.21 at the moment) AGP to 8.2
AndroidX Core to 1.12
CameraX to 1.3.1
Compose to 2023.10.01