-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/normalise function - tweak the name of the function that standardises input number format #20
Conversation
…w us to pass integers as potential NHS numbers and have them converted to standardised, 10-digit, zero-padded strings
…d pass-through. This is so existing code will continue to work and allows us to stay as a 1.x release rather than a 2.x (if we decide that we want to do that)
Looks good code-wise, and I like the However, on Python 3.7 this PR causes errors on running the tests because of the line:
I kept to a fairly old Python version for the time being because wasn't sure how recent a Python version we are going to move to. If we are moving to only supporting >3.10 then we can leave this as-is. If we want to maybe include some older versions that might plausibly be in use we could aim for >3.8? Thoughts? |
I can't install Python 3.7 on my MacBook because it's an M2 chip and there isn't a version available for it that I've found via conda at least. I'll maybe look at Docker options. We should probably look to maintain 3.7 as a minimum, even though it is end-of-life soon (as you pointed out elsewhere, I think). |
OK how about I try to fix it here on 3.7 and I'll update the PR accordingly.
The rest of the code review was fine and I can then merge.
I will look into ways we can make GitHub Actions run the tests against a
matrix of our supported Python versions, as a pre-approval check which must
pass before deployment to test.pypi.org or pypi.org(live) can occur. I
figure this is the setup you had with Travis, as there is a list of
versions in the Travis CI config file.
…On Mon, 12 Jun 2023 at 13:37, Andy Law ***@***.***> wrote:
I can't install Python 3.7 on my MacBook because it's an M2 chip and there
isn't a version available for it that I've found via conda at least. I'll
maybe look at Docker options. We should probably look to maintain 3.7 as a
minimum, even though it is end-of-life soon (as you pointed out elsewhere,
I think).
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5KYJRKL7ADCJHBKPRS6TXK4EQVANCNFSM6AAAAAAZDH4EGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Perfect. Thanks |
…ype annotation from 3.10 (details of this change in PEP604)
Good save, sir! |
Code changes to rename the function (and the enclosing file), allow pre-existing code to continue to work but be issued a deprecation warning, handle int arguments for a particular edge case