Chi dob validation #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check first six digits of a CHI are a date. Check when sex is added as an option it matches CHI number. Changed generate to supply numbers from synth range by default. Made sure generate supplies valid CHI numbers. Added tests.
Updated usage docs to inlude example. Removed CHI number support warnings. Updated Changelog
Incorrect use of warns(None) to assert no warning is raised. Pytest 7 requires different syntax. See https://docs.pytest.org/en/7.0.x/how-to/capture-warnings.html#additional-use-cases-of-warnings-in-tests for details
Changed the way a sex is specified to accept booleans for is_male or is_female
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for full CHI number validation and generation. Generate now uses synthetic numbers as the default.
I have removed all the warnings about the lack of support and adjusted the roadmap.