Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Return failed status and code 400 for unsuccessful requests #71

Closed
oliver-tarrant-tessella opened this issue Nov 22, 2018 · 2 comments
Closed
Assignees
Projects

Comments

@oliver-tarrant-tessella
Copy link
Collaborator

oliver-tarrant-tessella commented Nov 22, 2018

Acceptance criteria

Failed requests should return a status: fail and status code: 400 or 404, where appropriate, when unsuccessful requests are made. This includes:

  • listpresent to a bucket that doesn't exist
  • copydir, copynew, copyupdate when a directory doesn't exist or bucket doesn't exist
  • deletefile when file doesn't exist or bucket doesn't exist
  • createbucket when bucket name is rejected or already exists
@oliver-tarrant-tessella oliver-tarrant-tessella created this issue from a note in ditto (Backlog) Nov 22, 2018
@oliver-tarrant-tessella oliver-tarrant-tessella moved this from Backlog to Ready in ditto Nov 22, 2018
@oliver-tarrant-tessella oliver-tarrant-tessella moved this from Ready to In progress in ditto Nov 22, 2018
@robert-clegg-tessella robert-clegg-tessella moved this from In progress to Backlog in ditto Nov 23, 2018
@daniel-hunt-tessella
Copy link
Contributor

Remember to add the relevant status and status code checks to the system tests when fixing these requests

@oliver-tarrant-tessella oliver-tarrant-tessella moved this from Backlog to In progress in ditto Dec 3, 2018
@oliver-tarrant-tessella oliver-tarrant-tessella moved this from In progress to In review & testing in ditto Dec 6, 2018
robert-clegg-tessella added a commit that referenced this issue Dec 6, 2018
…lect-failed-requests/#71

Feature/status codes and status reflect failed requests/#71
@daniel-hunt-tessella
Copy link
Contributor

Testing:

  • listpresent for a bucket that does not exist returns a fail status and a 404 status code
  • copydir, copynew, and copyupdate all return a 404 if the directory or bucket do not exist
  • deletefile returns a 404 if the bucket or file does not exist
  • createbucket returns a 400 if the bucket name is invalid or the bucket already exists

@daniel-hunt-tessella daniel-hunt-tessella moved this from In review & testing to Done in ditto Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
ditto
  
Done
Development

No branches or pull requests

2 participants