Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start of geometry glueing tool #10

Merged
merged 31 commits into from
Dec 8, 2021
Merged

start of geometry glueing tool #10

merged 31 commits into from
Dec 8, 2021

Conversation

smason
Copy link
Contributor

@smason smason commented Nov 17, 2021

import SALOME code, refactored to suit the overlap_checker

will be calling the tool merge_solids

@smason smason marked this pull request as draft November 17, 2021 13:01
i.e. not contained in a COMPOUND or COMPSOLID
test geometry isn't flat and just allowing solids to be loaded doesn't
feel nice as it removes nice ordering of solids relied on by later
tools
might want to relax this a bit: e.g. just log the error and return
zero, but seems useful to know when this constrain is violated
hope it's okay with just this one, I pulled code from a number of
files across the repo
@smason smason linked an issue Nov 24, 2021 that may be closed by this pull request
@smason smason marked this pull request as ready for review December 8, 2021 17:05
not sure how I forgot it!
@smason smason merged commit cfd8a50 into main Dec 8, 2021
@smason smason deleted the shape-merge-tool branch December 8, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support glueing / merging of resulting objects
1 participant