Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do something sensible when opencasde returns negative volumes #23

Merged
merged 5 commits into from
Feb 1, 2022
Merged

do something sensible when opencasde returns negative volumes #23

merged 5 commits into from
Feb 1, 2022

Commits on Jan 31, 2022

  1. return absolute value of negative volumes 

    also log a warning
    @smason
    smason committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    8cea6b6 View commit details
    Browse the repository at this point in the history

  2. improve warning message

    @smason
    smason committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    e6b4864 View commit details
    Browse the repository at this point in the history

  3. we only seem to get negative volumes from BOPAlgo_COMMON

    @smason
    smason committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    7e704b1 View commit details
    Browse the repository at this point in the history

  4. not sure where this space came from!

    @smason
    smason committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    cea21db View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. record shapes with negative intersecting volume as touching 

    after sleeping on my change last night, this seems like the least bad
solution. at least until this gets fixed in OCCT!

this limit of 10% is debatable, in practice I've only seen volumes of
smaller than 0.1% so should be generous.
    @smason
    smason committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    92bde96 View commit details
    Browse the repository at this point in the history