Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 1 #24

Closed
wants to merge 3 commits into from
Closed

Patch 1 #24

wants to merge 3 commits into from

Conversation

zynine-
Copy link

@zynine- zynine- commented May 2, 2018

Added channel id (channel number) to display-name subelement for better compatibility with HDHRViewer V2

@zynine- zynine- mentioned this pull request May 2, 2018
Closed
mm98
mm98 reviewed May 29, 2018
View reviewed changes
Contents/Code/__init__.py
@@ -129,6 +129,7 @@ def doCreateXMLFile(menuCall = False):
for Channel in Channels:
channel = ET.SubElement(root, 'channel', id=str(Channel['id']))
ET.SubElement(channel, 'display-name').text = ValidateXMLStr(Channel['name'])
ET.SubElement(channel, 'display-name').text = str(Channel['id']))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work ... "display-name" attribute (line 131) is overwritten with the channel Id (line 132). Might wanna change the attribute name from "display-name" to ex. "channel-id".

@ukdtom
Copy link
Owner

ukdtom commented May 29, 2018

Closing for now, since @mm98 is correct here.
Please create a new one, with a desired name that would work with your plugin, but doesn't collide with existing naming

@ukdtom ukdtom closed this May 29, 2018
@zynine-
Copy link
Author

zynine- commented May 31, 2018

It won't overwrite it, it will create another subelement. The end result is:

  <channel id="1">
    <display-name>DR1</display-name>
    <display-name>1</display-name>
    <icon src="http://cloud.yousee.tv/static/img/logos/Large_DR_1.png"/>
  </channel>

which is similar to other types of XMLTV format that I have seen. It appears fine in Plex.

@ukdtom ukdtom reopened this Jun 1, 2018
@ukdtom
Copy link
Owner

ukdtom commented Jun 2, 2018

Sadly can't merge, due to me not knowing Git that well :(
(Did a lot of pep8 before this, that was unmerged, and since that contained changes to almost every line, I could not risk loosing that)
So your changes has been added manually, and verified...
Thanks

@ukdtom ukdtom closed this Jun 2, 2018
@ukdtom
Copy link
Owner

ukdtom commented Jun 2, 2018

https://forums.plex.tv/discussion/comment/1677628/#Comment_1677628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm98 mm98 mm98 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zynine- @ukdtom @mm98