Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include 2 #555

Merged
merged 1 commit into from Mar 4, 2019
Merged

Include 2 #555

merged 1 commit into from Mar 4, 2019

Conversation

hfm
Copy link
Contributor

@hfm hfm commented Mar 4, 2019 •
edited

DESCRIPTION HERE

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible
  • feature works in elasticsearch_dynamic (not required but recommended)

cosmo0920
cosmo0920 approved these changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Looks good. 👍

@cosmo0920 cosmo0920 merged commit 4ff16a2 into uken:master Mar 4, 2019
@hfm hfm deleted the include-2 branch March 4, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hfm @cosmo0920