Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a fix to the bug leading to PICARDPATH env variable being ignored #10

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Conversation

andersgs
Copy link
Contributor

Hello.

I fixed a bug where the PICARDPATH environmental variable was being ignored, which lead to no index being produced in a new DB.

For consistency with PHEnix, I changed the variable PICARDPATH to PICARD_JAR and updated the README to reflect that.

I also corrected some minor typos in the README.

To reflect the changes, I suggested a minor version number bump to 1.0.1. I changed that in the VERSION file and in the README.

Cheers.

Anders.

@andersgs
Copy link
Contributor Author

Ops. I just spotted a typo in my line directing the user to set a PICARD_JAR environmental file in the README.

Currently, it reads:
Set *PICARD_JAR* - full path to the GATK Java archive.

But, perhaps should be:

Set *PICARD_JAR* - full path to the Picard Java archive.

Sorry about that.

@timdallman
Copy link
Contributor

Accepted pull request to remove picard conflict

@timdallman timdallman merged commit 863e61d into ukhsa-collaboration:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants