Skip to content

Commit

Permalink
test(cli/inspector_port_collision): fail rather than hang (denoland#6991
Browse files Browse the repository at this point in the history
)
  • Loading branch information
piscisaureus committed Aug 8, 2020
1 parent f22b7dc commit 9806933
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions cli/tests/integration_tests.rs
Expand Up @@ -2934,10 +2934,10 @@ async fn inspector_port_collision() {
.unwrap();

let stderr_1 = child1.stderr.as_mut().unwrap();
let mut stderr_lines_1 = std::io::BufReader::new(stderr_1)
let mut stderr_1_lines = std::io::BufReader::new(stderr_1)
.lines()
.map(|r| r.unwrap());
let _ = extract_ws_url_from_stderr(&mut stderr_lines_1);
let _ = extract_ws_url_from_stderr(&mut stderr_1_lines);

let mut child2 = util::deno_cmd()
.arg("run")
Expand All @@ -2947,15 +2947,13 @@ async fn inspector_port_collision() {
.spawn()
.unwrap();

use std::io::Read;
let mut stderr_str_2 = String::new();
child2
.stderr
.as_mut()
.unwrap()
.read_to_string(&mut stderr_str_2)
.unwrap();
assert!(stderr_str_2.contains("Cannot start inspector server"));
let stderr_2 = child2.stderr.as_mut().unwrap();
let stderr_2_error_message = std::io::BufReader::new(stderr_2)
.lines()
.map(|r| r.unwrap())
.inspect(|line| assert!(!line.contains("Debugger listening")))
.find(|line| line.contains("Cannot start inspector server"));
assert!(stderr_2_error_message.is_some());

child1.kill().unwrap();
child1.wait().unwrap();
Expand Down

0 comments on commit 9806933

Please sign in to comment.