Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add minecraft.txt for Minecraft #72

Merged
merged 5 commits into from
Feb 17, 2019

Conversation

some-username-here1
Copy link
Contributor

What CDN does this PR relate to

A previously available CDN before it was deleted without a valid reasoning.

Does this require running via sniproxy

N/A (does it mean a "No" if you can download the files via http anyway?)

Capture method

Via the minecraft launcher log

Testing Scenario

Testing Configuration

<!-- Paste either your docker run command from the DNS container OR explain how you have setup DNS zone files etc to test this issue -->

@Lepidopterist
Copy link
Collaborator

Mionecraft is now https ( as per #45 ) and not cacheable. Please provide evidence this is incorrect, and we will update.

@some-username-here1
Copy link
Contributor Author

some-username-here1 commented Feb 16, 2019

Is this still appliable as evidence? (all being linked via http)

launchermeta.mojang.com

pre-1.6.json
1.9.json
1.13.1.json

launcher.mojang.com

client.jar (1.3.2)
client.jar (1.9)
client-1.7.xml is forced through https (and redirected from http), so sniproxy is required to be used here if possible

resources.download.minecraft.net

asset object 1
asset object 2
asset object 3
asset object 4
asset object 5
asset object 6

I've tested these through my web browser, being Firefox and Chromium, so I didn't mean to provide invalid evidence if it's handled a different way.
Also I couldn't test libraries.minecraft.net as that returned a 403 "Bad request." Error either way (http or https)

@some-username-here1
Copy link
Contributor Author

Or is this all invalid with the Minecraft Launcher going through https?
since I do want to try to redirect https to http for this, when possible

Removed inline comments due to concerns over script parsing
@VibroAxe
Copy link
Member

@some-username-here1 I'm happy to merge this, you've done a good investigative job. Thanks

Can you please mark this as ready for review so we can continue

@some-username-here1
Copy link
Contributor Author

some-username-here1 commented Feb 17, 2019

With libraries.minecraft.net and resources.minecraft.net (I don't remember what this was used for, but I'll look on that) being included? Though that can be tested and then the file can be changed on feedback with what's the log (and access log) is outputting...

@VibroAxe
Copy link
Member

if libraries.minecraft at least returns 403 on http that means it's listening, we can merge it so you can test it properly with steamcache-dns, if it doesn't work I can revert it back

@some-username-here1
Copy link
Contributor Author

Alright!

@some-username-here1 some-username-here1 marked this pull request as ready for review February 17, 2019 18:48
@VibroAxe VibroAxe merged commit 51d2faf into uklans:master Feb 17, 2019
@VibroAxe
Copy link
Member

@some-username-here1 let me know if you have any issues

@some-username-here1
Copy link
Contributor Author

Since it's now been merged, is there a way to update my current containers so that the minecraft service can be added, or I don't need to?

@VibroAxe
Copy link
Member

aye, restarting the containers should pull the latest list

@some-username-here1
Copy link
Contributor Author

Should I be concerned that the access.log isn't outputting anything? with using tail -f, or should I just wait for a while for it to go into effect?

Note: Nevermind, I looked into the log for my steamcache-dns container and it's looping with UPSTREAMDNS not having a ; in-between the IPv4 Addresses, will update once that's fixed

VibroAxe added a commit that referenced this pull request Feb 17, 2019
This reverts commit 51d2faf, reversing
changes made to cc21c7e.
VibroAxe added a commit that referenced this pull request Feb 17, 2019
This reverts commit 51d2faf, reversing
changes made to cc21c7e.
@some-username-here1 some-username-here1 deleted the minecraft branch February 17, 2019 22:11
@some-username-here1 some-username-here1 restored the minecraft branch February 17, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants