Electron - Packaged : Cannot read property 'stdout' of undefined

[BertholetDamien]

Hi @ukoloff !

I have an issue with Electron. When I packaged the application and launch it, I have this error :

Cannot read property 'stdout' of undefined

I just import it on the main thread with :
import 'win-ca';

I use :
Electron : 4.0.2
Electron-builder : 20.43.0
win-ca : 3.1.0

Can you help me with that ?
If you want any other information, tell me !

[ukoloff]

Yes, but unfortunately, I have no experience with that ASAR thing.

1. I believe, bad things happen at win-ca/lib/fallback.js at line 86. Can you patch it manually to something like:

  function run(callback){
    child_process.execFile(bin, args)
       .on('error', function(err){console.log('ERROR', err})
  }

repack, run and see what will appear in console?

2. I'd recommend to mark win-ca/lib/roots.exe as unpack when packing with ASAR. Not sure what it really means, but looks like it can help.

[BertholetDamien]

Thank for the quick answer.

I just look, win-ca is already unpack when I build with electron-builder.

But the path for the executable is not good. At the top of the fallback.js, I used that to make it work :

bin = path.join(__dirname, 'roots').replace('app.asar', 'app.asar.unpacked');

And I think a correct version for the run function can be :

function run(callback){
    child_process.execFileSync(bin, args);
    callback();
  }

I just try it and I can make the application start the two changes.
Can you provide a version with theses fix ?

Thank a lot @ukoloff !

[ukoloff]

But the path for the executable is not good.

Oh, this explains a lot.

Can you provide a version with theses fix ?

Sure, it will follow. But I want to see everything myself, there are too many complains concerning ASAR, I should understand it.

[ukoloff]

I'm totally stuck with ASAR + Electron.

I confirm that changing path to roots.exe fixes the problem.

But I don't understand, how we get incorrect path. If whole win-ca is unpacked, it should run from app.asar.unpacked (so no patch is neccessary)! If it runs from app.asar, documentation says the path to executable should be patched correctly. But it's obviously not.

Then, okay, roots.exe is not found. execFile should return ChildProcess in error state (and it does so in pure Node.js). Instead we get undefined. API is changed in Electron?

And I have no idea how to debug all this. Developer tools are disabled.

Is it possible to get Developer tools (in application packed with electron-builder)

And I think a correct version for the run function can be :

Helas! This breaks win-ca testing suite. In fact this turns async enumeration off.

So far I need more time to mess in the guts of Electron + ASAR. Be patient. please and help me with Developer Tools if you can.

[ukoloff]

By the way, do you know how to force win-ca to be packed into ASAR (disable auto-unpacking)?

[ukoloff]

After some exploration, I think: creators of Electron, ASAR, electron-builder etc. over-Microsofted Microsoft itself! This may work (and it works) but such a nightmare should not exist.

So, my only idea is to patch path to roots.exe manually in the code (as you did). It clearly works in your scenario. But if one pack win-ca into ASAR, it will break.

I believe it is a bug inside of asar's patch of child_process module. The point of ASAR is to handle this situation without fiddling the path, but it clearly fails to do so. May be you could post issue to electron-builder and discuss the situation with someone who understands what the fuck happens.

For a long period I amazed the huge wave of criticism on every mention of Electron at one russian IT-site (habr.com to be certain). Now I understand them. It's really awful.

Sorry, but I cannot afford supporting that.

[BertholetDamien]

Thank you a lot for your time @ukoloff.

I will check how I can fix my issue with all of that when I will have time.

[Ruffus2000]

By the way, do you know how to force win-ca to be packed into ASAR (disable auto-unpacking)?

in package.json

"asar": {
"smartUnpack": false
},

[Ruffus2000]

electron/electron#9459

i think this is the key

[ukoloff]

Well, I added dummy callback for execFile. Meet v3.1.1! вт, 27 окт. 2020 г. в 23:07, Felix Heidrich <notifications@github.com>:

…

I am still forced to use an old Electron build (1.8.8) and I am running into this issue with win-ca 3.3.0. The problem appears to simply be that the asar modified execFile version (from node 8.2.1) does not like the callback to be undefined -- it's optional, wtf. In case it still helps someone, here is an ugly monkey patch: const child_process = require('child_process'); const origExecFile = child_process.execFile; child_process.execFile = function(bin, args, callback) { if (callback === undefined) { callback = () => {} } origExecFile(bin, args, callback); } const ca = require('win-ca'); — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAROH6EZ4YET7DRUHGLA4XLSM4D6LANCNFSM4IBRHBTA> .

-- Удачи! =Стас