Completed refactor

ukparliament · Apr 19, 2017 · 5dda347 · 5dda347
1 parent a4fbea5
commit 5dda347
Show file tree

Hide file tree

Showing 211 changed files with 113 additions and 18,786 deletions.
diff --git a/Gemfile b/Gemfile
@@ -6,5 +6,5 @@ gemspec
 # Include coveralls for CI coverage reports
 gem 'coveralls', require: false
 
-# gem 'parliament-grom-decorators', git: 'https://github.com/ukparliament/parliament-grom-decorators', branch: 'master'
 gem 'parliament-grom-decorators', path: '../parliament-grom-decorators'
+gem 'parliament-ntriple', path: '../parliament-ntriple'
diff --git a/lib/parliament.rb b/lib/parliament.rb
@@ -5,7 +5,6 @@
 require 'parliament/request'
 require 'parliament/response'
 require 'parliament/utils'
-require 'parliament/decorator'
 require 'parliament/builder'
 
 require 'parliament/network_error'

diff --git a/lib/parliament/builder/base_response_builder.rb b/lib/parliament/builder/base_response_builder.rb
@@ -1,12 +1,21 @@
 module Parliament
   module Builder
+    # API response builder, allowing the user to return the body of an HTTPResponse.
+    # @since 0.7.5
     class BaseResponseBuilder
-      def initialize(response)
+      # Creates a new BaseReponseBuilder.
+      # @param [HTTPResponse] response an HTTP response containing n-triple data.
+      # @param [Module] decorators the decorator modules to provide alias methods to the resulting objects.
+      def initialize(response:, decorators: nil)
         @response = response
+        @decorators = decorators
       end
 
+      # Builds a Parliament::Response::BaseResponse.
+      #
+      # @return [Parliament::Response::Base::Response] a Parliament::Response::BaseResponse containing the HTTPResponse.
       def build
-        @response
+        Parliament::Response::BaseResponse.new(@response)
       end
     end
   end

diff --git a/lib/parliament/decorator.rb b/lib/parliament/decorator.rb
diff --git a/lib/parliament/decorator/constituency_area.rb b/lib/parliament/decorator/constituency_area.rb
diff --git a/lib/parliament/decorator/constituency_group.rb b/lib/parliament/decorator/constituency_group.rb
diff --git a/lib/parliament/decorator/contact_point.rb b/lib/parliament/decorator/contact_point.rb
diff --git a/lib/parliament/decorator/gender.rb b/lib/parliament/decorator/gender.rb
diff --git a/lib/parliament/decorator/gender_identity.rb b/lib/parliament/decorator/gender_identity.rb
diff --git a/lib/parliament/decorator/house.rb b/lib/parliament/decorator/house.rb
diff --git a/lib/parliament/decorator/house_incumbency.rb b/lib/parliament/decorator/house_incumbency.rb
diff --git a/lib/parliament/decorator/house_seat.rb b/lib/parliament/decorator/house_seat.rb